GitLab support #246
Merged
GitLab support #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-meloni
commented
Jun 15, 2019
| return dateFormatter | ||
| } | ||
| } | ||
|
|
||
| private final class OptionalFractionalSecondsDateFormatter: DateFormatter { |
There was a problem hiding this comment.
GitLab returns the dates with milliseconds in it.
Looks that decoder.dateDecodingStrategy = .iso8601 doesn't support that, then I created a new dateFormatter that can be used in decoder.dateDecodingStrategy = .formatted
f-meloni
commented
Jun 15, 2019
| createdAt: Date(timeIntervalSince1970: 1558561570), | ||
| updatedAt: Date(timeIntervalSince1970: 1558566949), | ||
| closedAt: Date(timeIntervalSince1970: 1558566946), | ||
| createdAt: Date(timeIntervalSince1970: 1_558_561_570), |
f-meloni
force-pushed
the
gitlab_support
branch
2 times, most recently
from
8c1623d
to
99653a5
Compare
Closed
This was referenced Jun 20, 2019
|
Can't find any info how to use it with gitlab? And does it support working with gitlab only (posting comment to gitlab MR's)? |
|
I'd look at the danger-js website for features - and ideally go bring some of those docs over to the swift site |
|
Currently GitLab support is affected by this issue though danger/danger-js#875, then could be that the usage of it won't return or (this is what I saw from my tests) returns after a while |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #247
馃帀