Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitLab support #246

Merged
merged 9 commits into from Jun 19, 2019

Conversation

@f-meloni
Copy link
Member

commented Jun 15, 2019

Fixes #247
馃帀

return dateFormatter
}
}

private final class OptionalFractionalSecondsDateFormatter: DateFormatter {

This comment has been minimized.

Copy link
@f-meloni

f-meloni Jun 15, 2019

Author Member

GitLab returns the dates with milliseconds in it.
Looks that decoder.dateDecodingStrategy = .iso8601 doesn't support that, then I created a new dateFormatter that can be used in decoder.dateDecodingStrategy = .formatted

createdAt: Date(timeIntervalSince1970: 1558561570),
updatedAt: Date(timeIntervalSince1970: 1558566949),
closedAt: Date(timeIntervalSince1970: 1558566946),
createdAt: Date(timeIntervalSince1970: 1_558_561_570),

This comment has been minimized.

Copy link
@f-meloni

f-meloni Jun 15, 2019

Author Member

swiftformat 馃し鈥嶁檪

@f-meloni f-meloni changed the title Gitlab support GitLab support Jun 15, 2019

@f-meloni f-meloni force-pushed the gitlab_support branch 2 times, most recently from 8c1623d to 99653a5 Jun 15, 2019

@f-meloni f-meloni force-pushed the gitlab_support branch from 99653a5 to 09d1562 Jun 15, 2019

f-meloni added some commits Jun 16, 2019

@f-meloni f-meloni referenced this pull request Jun 19, 2019

Closed

Support GitLab CI #247

@f-meloni f-meloni merged commit a20ee9c into master Jun 19, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the gitlab_support branch Jun 19, 2019

@jaroslavas

This comment has been minimized.

Copy link

commented Jul 11, 2019

Can't find any info how to use it with gitlab? And does it support working with gitlab only (posting comment to gitlab MR's)?

@orta

This comment has been minimized.

Copy link
Member

commented Jul 11, 2019

I'd look at the danger-js website for features - and ideally go bring some of those docs over to the swift site

@f-meloni

This comment has been minimized.

Copy link
Member Author

commented Jul 11, 2019

Currently GitLab support is affected by this issue though danger/danger-js#875, then could be that the usage of it won't return or (this is what I saw from my tests) returns after a while

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can鈥檛 perform that action at this time.