Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle not existing user #252

Merged
merged 4 commits into from Jun 29, 2019

Conversation

@f-meloni
Copy link
Member

commented Jun 27, 2019

If the user is not registered on GitHub the JSON we receive has {} in the author field for the commit.
This maybe can be fixed at danger-js level to just return nil in that case maybe, but I didn't see any obvious way? (any idea @orta?)
For the moment I added a patch to the problem

@DangerCI

This comment has been minimized.

Copy link

commented Jun 27, 2019

Warnings
⚠️

Sources/Danger/GitHubDSL.swift#L154 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L170 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L184 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L227 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L240 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L271 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L291 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L349 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L377 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L428 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L452 - Enum element name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L471 - Variable name should be between 3 and 40 characters long: 'id' (identifier_name)

⚠️

Sources/Danger/GitHubDSL.swift#L505 - File should contain 400 lines or less: currently contains 505 (file_length)

Generated by 🚫 Danger Swift against 9a65335

@f-meloni f-meloni force-pushed the not_existing_user branch from f8f7433 to 0065317 Jun 29, 2019

@f-meloni

This comment has been minimized.

Copy link
Member Author

commented Jun 29, 2019

Failing because of danger/danger-js#884

@f-meloni f-meloni merged commit c30be86 into master Jun 29, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@f-meloni f-meloni deleted the not_existing_user branch Jun 29, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.