Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Danger dependencies resolver #303

Merged
merged 19 commits into from
Jan 3, 2020
Merged

Danger dependencies resolver #303

merged 19 commits into from
Jan 3, 2020

Conversation

f-meloni
Copy link
Member

Given Marathon is now deprecated JohnSundell/Marathon#208
I've though was the case for Danger to bring the part it needed of Marathon in the project, and keep maintaining it.
I've taken this opportunity also to make the code more modular, testable and optimised.
This also removes a lot of dependencies, that means the build time of Danger will be a lot faster.
But is still 100% compatible with the Marathon cache of the previous version.

To compare the two version I've used the Moya repo

This is when there is no cache
Schermata 2019-12-01 alle 21 19 26

This is when there is a cache
Schermata 2019-12-15 alle 23 43 25

And those two are the same tests with the old code
Schermata 2019-12-15 alle 23 39 57
Schermata 2019-12-15 alle 23 37 29

After this PR is merged I will anyway make a new major release

@sunshinejr
Copy link
Member

this is huge!! didn't have time to go through it all, but it's a massive amount of work (oh and also congratz on the perf!) @f-meloni 👏

@orta
Copy link
Member

orta commented Dec 16, 2019

Very cool

@f-meloni f-meloni mentioned this pull request Dec 21, 2019
@f-meloni f-meloni marked this pull request as ready for review January 1, 2020 20:09
@f-meloni f-meloni merged commit f931d5c into master Jan 3, 2020
@f-meloni f-meloni deleted the dependency_resolver branch January 3, 2020 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants