-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Danger dependencies resolver #303
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is huge!! didn't have time to go through it all, but it's a massive amount of work (oh and also congratz on the perf!) @f-meloni 👏 |
Very cool |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given Marathon is now deprecated JohnSundell/Marathon#208
I've though was the case for Danger to bring the part it needed of Marathon in the project, and keep maintaining it.
I've taken this opportunity also to make the code more modular, testable and optimised.
This also removes a lot of dependencies, that means the build time of Danger will be a lot faster.
But is still 100% compatible with the Marathon cache of the previous version.
To compare the two version I've used the Moya repo
This is when there is no cache
![Schermata 2019-12-01 alle 21 19 26](https://user-images.githubusercontent.com/17830956/70871175-4024dd00-1f94-11ea-9086-2c0f8294f41c.png)
This is when there is a cache
![Schermata 2019-12-15 alle 23 43 25](https://user-images.githubusercontent.com/17830956/70871225-b45f8080-1f94-11ea-9ae1-b8bc55685133.png)
And those two are the same tests with the old code
![Schermata 2019-12-15 alle 23 39 57](https://user-images.githubusercontent.com/17830956/70871188-60ed3280-1f94-11ea-81f8-0c14c3d2bfb8.png)
![Schermata 2019-12-15 alle 23 37 29](https://user-images.githubusercontent.com/17830956/70871190-65195000-1f94-11ea-9d17-7468228dbb44.png)
After this PR is merged I will anyway make a new major release