Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Makefile to copy third party libraries recursively #331

Merged
merged 1 commit into from
Mar 31, 2020
Merged

fix: update Makefile to copy third party libraries recursively #331

merged 1 commit into from
Mar 31, 2020

Conversation

lucasmpaim
Copy link
Contributor

When using install with homebrew we got this error:

Last 15 lines from /Users/lucaspaim/Library/Logs/Homebrew/danger-swift/01.make:
[5/10] Compiling RunnerLib CliArgs.swift
[6/10] Compiling DangerDependenciesResolver Data+Encoding.swift
[7/11] Compiling Runner Edit.swift
[8/11] Linking danger-swift
[9/11] Compiling OctoKit Configuration.swift
[10/12] Compiling Danger BitBucketCloud.swift
[11/13] Linking libDanger.dylib
[12/13] Compiling DangerFixtures CustomGitHubDSL.swift
[13/13] Linking libDangerFixtures.dylib
mkdir -p /usr/local/Cellar/danger-swift/3.2.0/bin
mkdir -p /usr/local/Cellar/danger-swift/3.2.0/lib/danger
cp -f .build/release/danger-swift /usr/local/Cellar/danger-swift/3.2.0/bin/danger-swift
cp -f .build/release/libDanger.* .build/release/Danger.swiftdoc .build/release/Danger.swiftmodule .build/release/OctoKit.swiftdoc .build/release/OctoKit.swiftmodule .build/release/RequestKit.swiftdoc .build/release/RequestKit.swiftmodule .build/release/Logger.swiftdoc .build/release/Logger.swiftmodule .build/release/DangerShellExecutor.swiftdoc .build/release/DangerShellExecutor.swiftmodule /usr/local/Cellar/danger-swift/3.2.0/lib/danger
cp: .build/release/libDanger.dylib.dSYM is a directory (not copied).
make: *** [install] Error 1

This PR fixes it

@lucasmpaim lucasmpaim requested a review from orta March 31, 2020 19:52
@orta
Copy link
Member

orta commented Mar 31, 2020

Cool, this makes sense to me - I wonder what changed to make it need to happen

@orta orta merged commit 406dbb9 into danger:master Mar 31, 2020
@f-meloni
Copy link
Member

I think is changed how OSX threats them, from Catalina

@peril-staging
Copy link
Contributor

peril-staging bot commented Mar 31, 2020

Thanks for the PR @lucasmpaim.

This PR has been shipped in v3.2.1 - CHANGELOG.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants