Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many people prefers using the SPM Danger configuration, because is more performing.
Having a Package.swift on your root folder can be annoying, especially now that Xcode (from 11) doesn't put on the recents list an
xcproj
(orxcworkspace
) when there is aPackage.swift
in the same folder.At the moment if you move the
Package.swift
in another folder Danger breaks because the path are relatives to the root folder.Of course the paths can be changed on the Dangerfile in order to have
..
or the full path, but this would not work for example for Plugins where the path is automatically taken from Danger's modified files.This is why I thought would be nice to offer a
current work directory
option to make you run danger like it was in the root folder of your project even if you have it somewhere else.I can also think this could be useful in cases like https://github.com/WeTransfer/WeTransfer-iOS-CI/tree/master/Danger-Swift where you have your CI configuration in a separated repo.
PS. this change to work requires the changes on danger/danger-js#1021
@orta can you please release a new danger-js version?