Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to enviroment #431

Merged
merged 5 commits into from
Apr 19, 2021
Merged

Add support to enviroment #431

merged 5 commits into from
Apr 19, 2021

Conversation

f-meloni
Copy link
Member

Inspired by Tuist's environment implementation, get with dynamic lookup any variable that starts with DANGER_

@github-actions
Copy link

github-actions bot commented Apr 13, 2021

Warnings
⚠️

Sources/RunnerLib/Runtime.swift#L38 - TODOs should be resolved (Support running from a fork?). (todo)

Generated by 🚫 Danger Swift against a4a3714


XCTAssertNil(environment.testValue)
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clever

CHANGELOG.md Outdated
@@ -1,4 +1,4 @@
<!--
!--
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems to be unexpected change, isn't it?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@f-meloni f-meloni merged commit a1c87ea into master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants