-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Homebrew path for Apple Silicon based macOS installations #458
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Can you please also update the Changelog? |
@f-meloni Sorry. I haven't had a chance to get to updating the changelog. Should I still do it or will you take care of that? To add full Apple Silicon compatibility, in addition to the change made in this PR, the tool itself will need to be compiled universally for both Apple Silicon and Intel. |
@majd No problem at all, I've updated it https://github.com/danger/swift/pull/461/files https://github.com/danger/homebrew-tap/blob/master/danger-swift.rb#L15 Is there anything missing there? |
I believe one of the libraries is still not being compiled for the current architecture. Here is the log.
I'm happy to take a look if needed. But do you have any ideas? I should probably open a separate issue regarding this. |
@majd thank you! I will make a release then! |
The Homebrew install path on Apple Silicon is different from the Intel-based Homebrew setup. This PR adds the new path to
Runtime.swift
to fix the error below.