Notify a new release on running danger-swift
#505
Conversation
| } | ||
| } | ||
|
|
||
| static func fetchLatestVersion() -> String? { |
| } | ||
|
|
||
| extension VersionChecker { | ||
| static let logger = Logger() |
There was a problem hiding this comment.
This Logger won't have the right set up, which is made based on the parameters passed to Danger Swift, not a big deal, but would be nice to get it from the runner if possible (is created at line 25)
There was a problem hiding this comment.
#505 (comment) may also resove it 😁
| import Foundation | ||
|
|
||
| public enum VersionChecker { | ||
| public static func checkForUpdate(current currentVersionString: String) { |
There was a problem hiding this comment.
Can inject ShellExecutor and Logger (which anyway can be needed), so that we can also have some tests for this logic?
There was a problem hiding this comment.
Fixed VersionChecker enum to class, which make it injectable 😄.
| import Version | ||
| import Foundation | ||
|
|
||
| public class VersionChecker { |
There was a problem hiding this comment.
Nitpick:
Can this be a struct? I prefer having structs if possible, following the Apple's suggested approach
Consider the following recommendations to help choose which option makes sense when adding a new data type to your app.
Use structures by default.
Use classes when you need Objective-C interoperability.
Use classes when you need to control the identity of the data you're modeling.
Use structures along with protocols to adopt behavior by sharing implementations.
from https://developer.apple.com/documentation/swift/choosing_between_structures_and_classes
| public init( | ||
| shellExecutor: ShellExecutor = .init(), | ||
| logger: Logger | ||
| ) { |
There was a problem hiding this comment.
Given this is now injectable, can we also add some tests for this please?
Co-authored-by: Franco Meloni <franco.meloni91@gmail.com>
Some tools (e.g.
carthage,gh, etc...) notify when new version is released.I added a version checker to fetch a latest release in GitHub, and notify if running version is older than latest.