Bump dependencies to avoid SwiftLint build-error in Swift 5.5.2 #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f-meloni
approved these changes
Feb 27, 2022
Package.swift
Outdated
| .package(url: "https://github.com/shibapm/Rocket", from: "0.4.0"), | ||
| .package(url: "https://github.com/SwiftDocOrg/swift-doc", .branch("1.0.0-rc.1")), | ||
| .package(url: "https://github.com/shibapm/Rocket", from: "1.2.1"), | ||
| // .package(url: "https://github.com/SwiftDocOrg/swift-doc", .branch("1.0.0-rc.1")), |
There was a problem hiding this comment.
Given this is been archived, I think we can remove it completely, will work on make docs separately
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some problem that SwiftLint build fails on Swift 5.5.2.
https://github.com/danger/swift/runs/5258863489?check_suite_focus=true#step:10:69
I tried to bump it and found version conflicts on some dependencies, so I make them all to latest.
Additionally, swift-docis archived and not maintained any more, which causes version conflict too.
It seems to be necessary to run
make docs, so I comment-out temporary instead of removing.