Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GET /icons/<domain>/icon.png panics for www.zborovna.sk #380

Closed
mprasil opened this issue Feb 3, 2019 · 3 comments
Closed

GET /icons/<domain>/icon.png panics for www.zborovna.sk #380

mprasil opened this issue Feb 3, 2019 · 3 comments
Labels
bug Something isn't working

Comments

@mprasil
Copy link
Contributor

mprasil commented Feb 3, 2019

I'm not sure what is causing it yet, this is what I see in the logs:

[2019-02-03 21:24:30][reqwest::async_impl::client][DEBUG] redirecting to GET 'https://www.zborovna.sk/novinky/index.php'
[2019-02-03 21:24:30][reqwest::async_impl::response][DEBUG] Response: '200 OK' for https://www.zborovna.sk/novinky/index.php
thread '<unnamed>' panicked at 'called `Result::unwrap()` on an `Err` value: ParseIntError { kind: InvalidDigit }', src/libcore/result.rs:997:5
@mprasil mprasil added the bug Something isn't working label Feb 3, 2019
@mprasil
Copy link
Contributor Author

mprasil commented Feb 3, 2019

As per discussion with @dani-garcia on our chat, this is most likely due to incorrect character in sizes attribute of <link rel="apple-touch-icon"> - the site is using "×" (multiplication character) instead of "x" to separate the numbers:

<link rel="apple-touch-icon" sizes="76×76" href="/images/touch-icon-ipad.png">

BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Feb 4, 2019
@BlackDex
Fixed issue dani-garcia#380
c13f115 
 - Created a separate function for parsing the sizes attribute
 - Parsing sizes now with regex
 - Should work with any non-digit separator
@BlackDex
Copy link
Collaborator

BlackDex commented Feb 4, 2019

Is fixed in: #381

dani-garcia added a commit that referenced this issue Feb 4, 2019
@dani-garcia
Merge pull request #381 from BlackDex/issue-380
48113b7 
Fixed issue #380
@dani-garcia
Copy link
Owner

Fixed in #381

thelittlefireman pushed a commit to thelittlefireman/bitwarden_rs that referenced this issue Mar 19, 2021
@BlackDex
Fixed issue dani-garcia#380
665f47e 
 - Created a separate function for parsing the sizes attribute
 - Parsing sizes now with regex
 - Should work with any non-digit separator
thelittlefireman pushed a commit to thelittlefireman/bitwarden_rs that referenced this issue Mar 19, 2021
@dani-garcia
Merge pull request dani-garcia#381 from BlackDex/issue-380
1d7348a 
Fixed issue dani-garcia#380
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@BlackDex @dani-garcia @mprasil