Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting all DUO_ environment variables does not enable duo integration #3382

Closed
tommyalatalo opened this issue Mar 27, 2023 · 0 comments · Fixed by #3436
Closed

Setting all DUO_ environment variables does not enable duo integration #3382

tommyalatalo opened this issue Mar 27, 2023 · 0 comments · Fixed by #3436
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided

Comments

@tommyalatalo
Copy link

Subject of the issue

There are three Duo related environment variables, DUO_HOST, DUO_IKEY and DUO_SKEY which according to this template should enable the duo integration when all of the variables are set. This is not working and the user actually needs to set the undocumented variable _ENABLE_DUO to true in order to enable the integration.

Deployment environment

    ### Your environment (Generated via diagnostics page)
    * Vaultwarden version: v1.28.0
    * Web-vault version: v2023.3.0b
    * OS/Arch: linux/x86_64
    * Running within Docker: true (Base: Alpine)
    * Environment settings overridden: true
    * Uses a reverse proxy: true
    * IP Header check: true (X-Forwarded-For)
    * Internet access: true
    * Internet access via a proxy: false
    * DNS Check: true
    * Browser/Server Time Check: true
    * Server/NTP Time Check: true
    * Domain Configuration Check: true
    * HTTPS Check: true
    * Database type: PostgreSQL
    * Database version: PostgreSQL 9.6.24 on x86_64-pc-linux-musl, compiled by gcc (Alpine 10.3.1_git20211027) 10.3.1 20211027, 64-bit
    * Clients used: 
    * Reverse proxy and version: 
    * Other relevant information: 


**Environment settings which are overridden:** DOMAIN, SIGNUPS_ALLOWED, INVITATIONS_ALLOWED, SHOW_PASSWORD_HINT, ADMIN_TOKEN, IP_HEADER, DUO_IKEY, DUO_SKEY, DUO_HOST, SMTP_HOST, SMTP_PORT, SMTP_FROM, SMTP_FROM_NAME, SMTP_USERNAME, SMTP_PASSWORD
  • vaultwarden version: 1.28.0
  • Install method: Docker

  • Other relevant details:

Steps to reproduce

  1. Configure container environment variables, including DUO_HOST, DUO_IKEY and DUO_SKEY
  2. Start container
  3. Go to admin panel and check the Global Duo settings and see that Duo is not enabled

Expected behaviour

Duo should be enabled automatically when DUO_HOST, DUO_IKEY and DUO_SKEY are set in the environment

Actual behaviour

Duo is not enabled automatically by the environment variables.

Troubleshooting data

The issue is likely due to this line in the conditional statement checking the Duo variables. It seems to set the conditional to true only if the undocumented variable _ENABLE_DUO is already true. A suggested solution would be to remove this part of the conditional to make the condition work as stated in the template.

@BlackDex BlackDex added enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided labels Mar 27, 2023
BlackDex added a commit to BlackDex/vaultwarden that referenced this issue Apr 10, 2023
- Fixed issue with domains starting with `admin`
- Fixed issue with DUO not being enabled globally anymore (regression)
- Renamed `Ciphers` to `Entries` in overview
- Improved `ADMIN_TOKEN` description
- Updated jquery-slim and datatables

Resolves dani-garcia#3382
Resolves dani-garcia#3415
Resolves discussion on dani-garcia#3288
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low priority Won't fix anytime soon, but will accept PR if provided
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants