Also list shared ciphers in find_by_user #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits the
find_by_user
into two separate functions:find_owned_by_user
which retains previous functionality and lists only ciphers directly owned by user andfind_by_user
which now also lists all ciphers shared with user.As a result shared ciphers are now visible in user's vault.
There's also small change in the
/api/ciphers/purge
handler to use thefind_owned_by_user
instead to only purge user's content and not the shared stuff.