Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge & rebase for pinpox SSO #2787

Closed
wants to merge 1 commit into from

Conversation

m4w0lf
Copy link

@m4w0lf m4w0lf commented Oct 2, 2022

Hi @pinpox,
I rebased you branch and I aligned it with current main on dani-garcia/vaultwarden.

Docker container builds successfully.

Can you help me to configure and test it?

@m4w0lf m4w0lf mentioned this pull request Oct 2, 2022
@pinpox
Copy link

pinpox commented Oct 4, 2022

Nice, thanks for working on this! What do you need help with exactly? Configuration is pretty straightforward with any Auth provider that supports OpenID connect. I tested it with Gitea specifically.

Should I integrate this changes into my PR?

@m4w0lf
Copy link
Author

m4w0lf commented Oct 4, 2022

I could not find the frontend part to configure the connection to the issuer, nor the step needed.
Maybe I can reach you by email / discord for help on configuring versus keycloak?

Maybe we can also talk how to appropriate squash and merge, like suggested here -> #2449 (comment)

@pinpox
Copy link

pinpox commented Oct 4, 2022

Maybe I can reach you by email / discord for help on configuring versus keycloak?

Sure you can reach me via mail or even better on matrix, I'm in the vaultwarden matrix channel aswell.

@blaubaer
Copy link

Dear participants,

From the whole conversation I'm not fully sure about the current state, therefore: I can support the finalization of this PR in some way? By testing or whatever? I like to support the finalization of that topic as soon as possible, because it will boost a lot of professional contexts. 😀

@KramNamez
Copy link

Seconding blaubaer - this is the only blocker keeping us from adopting Vaultwarden and I'd like to help make this happen, if at all possible.

@ROFISH
Copy link

ROFISH commented Nov 1, 2022

Thirding! If there is testing or some light additional work, I'm happy to help since this is the blocker we need to resolve before deployment.

@Eweol
Copy link

Eweol commented Dec 24, 2022

Is there any chance that this will be part of next release?

@Rutkv0
Copy link

Rutkv0 commented Jan 3, 2023

Any updates?

@himself1985
Copy link

himself1985 commented Jan 3, 2023 via email

@blaubaer
Copy link

blaubaer commented Jan 3, 2023

@m4w0lf Can you please at least tell us if you abandon this topic or if you're still planning to work on it OR if we (the community) needs to finds someone else to work on it?

@bmunro-peralex
Copy link

So i'll be creating another PR shortly that implements this. I got it working on my gitlab instance. Just trying to finalize the creating of users if they don't exist directly from the SSO call, instead of having the users need to be created first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants