New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
merge & rebase for pinpox SSO #2787
Conversation
Nice, thanks for working on this! What do you need help with exactly? Configuration is pretty straightforward with any Auth provider that supports OpenID connect. I tested it with Gitea specifically. Should I integrate this changes into my PR? |
I could not find the frontend part to configure the connection to the issuer, nor the step needed. Maybe we can also talk how to appropriate squash and merge, like suggested here -> #2449 (comment) |
Sure you can reach me via mail or even better on matrix, I'm in the vaultwarden matrix channel aswell. |
Dear participants, From the whole conversation I'm not fully sure about the current state, therefore: I can support the finalization of this PR in some way? By testing or whatever? I like to support the finalization of that topic as soon as possible, because it will boost a lot of professional contexts. 😀 |
Seconding blaubaer - this is the only blocker keeping us from adopting Vaultwarden and I'd like to help make this happen, if at all possible. |
Thirding! If there is testing or some light additional work, I'm happy to help since this is the blocker we need to resolve before deployment. |
Is there any chance that this will be part of next release? |
Any updates? |
Sehr geehrte Damen und Herren,
ich befinde mich aktuell im Urlaub und bin bis einschließlich 27.01.2023 nicht zu erreichen.
Ihre eMails werden nicht weitergeleitet.
In dringenden Fällen wenden Sie sich bitte an meinen Kollegen:
Matthias ***@***.***
i.A. Jonas Zimmermann
IT-Abteilung
GREIFF Mode GmbH & Co. KG
Memmelsdorfer Strasse 250
96052 Bamberg
Deutschland
+49 951 405 238
***@***.***
greiff.de
Visitenkarte als vCard
USt-IdNr.: DE 249 822 002 | Kommanditgesellschaft: Sitz Bamberg | Amtsgericht Bamberg HRA 10668
Persönlich haftende Gesellschafterin: GREIFF Mode Verwaltungs GmbH | Sitz Bamberg HRB 653
Geschäftsführer: Jens Möller
|
@m4w0lf Can you please at least tell us if you abandon this topic or if you're still planning to work on it OR if we (the community) needs to finds someone else to work on it? |
So i'll be creating another PR shortly that implements this. I got it working on my gitlab instance. Just trying to finalize the creating of users if they don't exist directly from the SSO call, instead of having the users need to be created first. |
Hi @pinpox,
I rebased you branch and I aligned it with current main on dani-garcia/vaultwarden.
Docker container builds successfully.
Can you help me to configure and test it?