Cleanups and Fixes for Emergency Access

[BlackDex]

• Several cleanups and code optimizations for Emergency Access
• Fixed a race-condition regarding jobs for Emergency Access
• Some other small changes like allow(clippy::) removals

Fixes #2925
Fixes #2955

[tessus]

I checked the other cron jobs as well and all of them are wrong.

Cron format:

*    *    *    *    *  Command_to_execute
|    |    |    |    |       
|    |    |    |    Day of the Week ( 0 - 6 ) ( Sunday = 0 )
|    |    |    |
|    |    |    Month ( 1 - 12 )
|    |    |
|    |    Day of Month ( 1 - 31 )
|    |
|    Hour ( 0 - 23 )
|
Min ( 0 - 59 )

According to @stefan0xC, the format is different than the standard cron format.

I'll open a PR to add this info to the template file. This is certainly not clear by just looking at the file....

Update: Scratch that too. It is in the .env.template file. Strange that I missed this.

[BlackDex]

Update: Scratch that too. It is in the .env.template file. Strange that I missed this.

That was in one of my updates, so it could be you didn't see a recent version.
Because of the difference between normal cron's and sometimes the complexity i thought to add some more info about it.

The seconds option is btw a nice addition, at least for me during testing, instead of having to wait a whole minute or 30 seconds hehe. But for that to work, you also need to change the JOB_POLL_INTERVAL_MS to a lower amount, say 500 (half a second), else it will not work, because the default is 30s

[tessus]

That was in one of my updates, so it could be you didn't see a recent version.

Yep, this is possible, because I remember I read the entire template file a while back and that part was new to me.

Because of the difference between normal cron's and sometimes the complexity i thought to add some more info about it.

Good idea. It definitely helps.

The seconds option is btw a nice addition, at least for me during testing,

Yep, I totally agree. Personally I would have just added new fields at the end, so that it is still compatible with the original format. But I also understand why the dev of the library wanted to have the seconds next to the minutes...