Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate note sizes on key-rotation. #3157

Merged
merged 1 commit into from Jan 24, 2023

Commits on Jan 24, 2023

  1. Validate note sizes on key-rotation.

    We also need to validate the note sizes on key-rotation.
    If we do not validate them before we store them, that could lead to a
    partial or total loss of the password vault. Validating these
    restrictions before actually processing them to store/replace the
    existing ciphers should prevent this.
    
    There was also a small bug when using web-sockets. The client which is
    triggering the password/key-rotation change should not be forced to
    logout via a web-socket request. That is something the client will
    handle it self. Refactored the logout notification to either send the
    device uuid or not on specific actions.
    
    Fixes dani-garcia#3152
    BlackDex committed Jan 24, 2023
    Copy the full SHA
    34ac16e View commit details
    Browse the repository at this point in the history