add information about docker-compose.yml to README.md #4100
Conversation
lumpsoid
commented
Nov 24, 2023
lumpsoid
commented
- added information on how this can be organized into a docker-compose.yml file for easier interaction.
- added a couple of examples of what happens in docker-compose.yml
- slightly reshaped the text in #Instalation
|
@williamdes is there anything else to improve? |
README.md
Outdated
| services: | ||
| vaultwarden: | ||
| container_name: vaultwarden | ||
| image: vaultwarden/server:1.30.0 |
There was a problem hiding this comment.
| image: vaultwarden/server:1.30.0 | |
| image: vaultwarden/server:1.30.1 |
There was a problem hiding this comment.
Because it may roll in production major releases without the author noticing.
I prefer range tags: like 1.30 or 1 for example. Alpine linux and other have this
There was a problem hiding this comment.
All right, I'll put the changes back in.
There was a problem hiding this comment.
I don't want to be a pain here. But we do not have range tags. And the current examples all use latest.
It might change in the future, but I would prefer to keep all examples the same, and no usage of versions. A lot of people tend to forget this and assume it will be charged automatically or something.
So i would prefer to keep latest for now.
There was a problem hiding this comment.
Yeah I agree, people forget to upgrade
Both ways it's a pain. Let's keep latest then
There was a problem hiding this comment.
Besides the changes suggested by the others i would also suggest to add the link to the wiki in regards of Docker Compose. It contains a bit more details and that page is easier to update by others too.
So, please also add the following link https://github.com/dani-garcia/vaultwarden/wiki/Using-Docker-Compose
BlackDex
force-pushed
the
docker-compose-example
branch
from
54d8c02
to
4e1a548
Compare
lumpsoid
force-pushed
the
docker-compose-example
branch
from
fe956e1
to
eccb3ab
Compare
