cancel brief removal of the dragover class when the event target changes

[tristan]

I found a small bug when animations where triggered upon adding the dragover class. As you move the mouse over child elements of the ng-file-drop element the dragleave event is fired, followed by a new dragover event. This can cause the animation attached to the dragover class to be triggered again, which is generally undesirable.

The fix is to simply tell the dragover event to cancel any pending removals of the dragover class. My fix works because the dragover event that will follow the dragleave event is already queued up to be processed after the dragleave event, and the $timout call queues up the removal of the class to happen after all pending events are processed, thus if the dragover event is in the queue it will cancel the removal of the class.

I've made a demo to try show this bug here: http://plnkr.co/QqxKMCsC3Xq6L64FWiZZ if you quickly drag file over the boxes you can often see the animated overlay bouncing/flickering (it's sometimes very subtle). here is the same demo with my changes http://plnkr.co/LXqS64wWEmyG3tD4xusT which doesn't suffer from this (NOTE: firefox seems to not have the issue, but it's visible on chrome and safari).

[tristan]

it's essentially a noop.
https://github.com/angular/angular.js/blob/master/src/ng/timeout.js#L76

On Wed, Feb 12, 2014 at 10:56 PM, danialfarid notifications@github.comwrote:

Thanks,
If the cancel is null would the $timeout.cancel(cancel) throw error or it
is noop?

Reply to this email directly or view it on GitHubhttps://github.com//pull/130#issuecomment-34922855
.

[danialfarid]

Fixed in version 1.2.8

[rayshan]

The problem is still there with Chrome 34.0.1847.92 beta-m and angular-file-upload 1.3.1. More info on the problem here: http://stackoverflow.com/questions/7110353/html5-dragleave-fired-when-hovering-a-child-element

Perhaps add a shared scope boolean variable ngHovered, so one can ngShow/ngHide the child elements?

[danialfarid]

So is it only happening for the beta version? The stable version of chrome works?

[rayshan]

Tested the below (all in Windows, can try Mac later when I get home):
Chrome Stable 34.0.1847.92 m 👎
Chrome Beta 34.0.1847.92 beta-m 👎
IE 11.0.9600.16521 👍
Firefox 28.0 👍

[danialfarid]

Could you explain more what exactly the problem is and create a plnkr or jsfiddle for it?
I tested the original bug with angular-file-upload 1.3.1 and everything seems to be working fine:
http://plnkr.co/edit/WacBZ79gnCFGKfjgRZlL
on Chrome 33.0.1750.154 m which shows as the latest version for me.