hd66753: Implement SGS drawing logic #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@daniel5151 Hi, I finally figured out why I was running into this issue. I'm not very happy with what I had to do to reverse the iterator when ireg.sgs, do you have a cleaner way of doing it? |
daniel5151
reviewed
Feb 5, 2024
It seems like iPod 4G diagnostics plays with the SGS bit, causing reversed display. Implementing this resolves the horizontally inverted display on the diagnostics screen.
jeanthom
force-pushed
the
lcd-driver-sgs
branch
from
070f2d3
to
9be591b
Compare
|
@daniel5151 Thanks for your feedback. I've applied your suggestion. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like iPod 4G diagnostics plays with the SGS bit, causing reversed display. Implementing this resolves the horizontally inverted display on the diagnostics screen.