Merge pull request #44 from kylef/unused

Make DAKeyboardControl build with -Wunused-parameter
danielamitay · May 5, 2013 · 72a06f2 · 72a06f2
2 parents 465501c + 74062b0
commit 72a06f2
Showing 1 changed file with 14 additions and 16 deletions.
diff --git a/DAKeyboardControl/DAKeyboardControl.m b/DAKeyboardControl/DAKeyboardControl.m
@@ -106,7 +106,7 @@ - (void)addKeyboardControl:(BOOL)panning actionHandler:(DAKeyboardDidMoveBlock)a
                                                  name:UIKeyboardWillShowNotification
                                                object:nil];
     [[NSNotificationCenter defaultCenter] addObserver:self
-                                             selector:@selector(inputKeyboardDidShow:)
+                                             selector:@selector(inputKeyboardDidShow)
                                                  name:UIKeyboardDidShowNotification
                                                object:nil];
 
@@ -116,7 +116,7 @@ - (void)addKeyboardControl:(BOOL)panning actionHandler:(DAKeyboardDidMoveBlock)a
                                                  name:@"UIKeyboardWillChangeFrameNotification"
                                                object:nil];
     [[NSNotificationCenter defaultCenter] addObserver:self
-                                             selector:@selector(inputKeyboardDidChangeFrame:)
+                                             selector:@selector(inputKeyboardDidChangeFrame)
                                                  name:@"UIKeyboardDidChangeFrameNotification"
                                                object:nil];
 
@@ -125,7 +125,7 @@ - (void)addKeyboardControl:(BOOL)panning actionHandler:(DAKeyboardDidMoveBlock)a
                                                  name:UIKeyboardWillHideNotification
                                                object:nil];
     [[NSNotificationCenter defaultCenter] addObserver:self
-                                             selector:@selector(inputKeyboardDidHide:)
+                                             selector:@selector(inputKeyboardDidHide)
                                                  name:UIKeyboardDidHideNotification
                                                object:nil];
 }
@@ -218,7 +218,7 @@ - (void)responderDidBecomeActive:(NSNotification *)notification
         }
         self.keyboardActiveInput = (UIResponder *)textField;
         // Force the keyboard active view reset
-        [self inputKeyboardDidShow:nil];
+        [self inputKeyboardDidShow];
     }
 }
 
@@ -246,7 +246,7 @@ - (void)inputKeyboardWillShow:(NSNotification *)notification
                          if (self.keyboardDidMoveBlock && !CGRectIsNull(keyboardEndFrameView))
                              self.keyboardDidMoveBlock(keyboardEndFrameView);
                      }
-                     completion:^(BOOL finished){
+                     completion:^(__unused BOOL finished){
                          if (self.panning && !self.keyboardPanRecognizer)
                          {
                              // Register for gesture recognizer calls
@@ -260,7 +260,7 @@ - (void)inputKeyboardWillShow:(NSNotification *)notification
                      }];
 }
 
-- (void)inputKeyboardDidShow:(NSNotification *)notification
+- (void)inputKeyboardDidShow
 {
     // Grab the keyboard view
     self.keyboardActiveView = self.keyboardActiveInput.inputAccessoryView.superview;
@@ -294,11 +294,10 @@ - (void)inputKeyboardWillChangeFrame:(NSNotification *)notification
                          if (self.keyboardDidMoveBlock && !CGRectIsNull(keyboardEndFrameView))
                              self.keyboardDidMoveBlock(keyboardEndFrameView);
                      }
-                     completion:^(BOOL finished){
-                     }];
+                     completion:nil];
 }
 
-- (void)inputKeyboardDidChangeFrame:(NSNotification *)notification
+- (void)inputKeyboardDidChangeFrame
 {
     // Nothing to see here
 }
@@ -323,14 +322,14 @@ - (void)inputKeyboardWillHide:(NSNotification *)notification
                          if (self.keyboardDidMoveBlock && !CGRectIsNull(keyboardEndFrameView))
                              self.keyboardDidMoveBlock(keyboardEndFrameView);
                      }
-                     completion:^(BOOL finished){
+                     completion:^(__unused BOOL finished){
                          // Remove gesture recognizer when keyboard is not showing
                          [self removeGestureRecognizer:self.keyboardPanRecognizer];
                          self.keyboardPanRecognizer = nil;
                      }];
 }
 
-- (void)inputKeyboardDidHide:(NSNotification *)notification
+- (void)inputKeyboardDidHide
 {
     self.keyboardActiveView.hidden = NO;
     self.keyboardActiveView.userInteractionEnabled = YES;
@@ -339,8 +338,8 @@ - (void)inputKeyboardDidHide:(NSNotification *)notification
 
 - (void)observeValueForKeyPath:(NSString *)keyPath
                       ofObject:(id)object
-                        change:(NSDictionary *)change
-                       context:(void *)context
+                        change:(__unused NSDictionary *)change
+                       context:(__unused void *)context
 {
     if([keyPath isEqualToString:@"frame"] && object == self.keyboardActiveView)
     {
@@ -441,8 +440,7 @@ - (void)panGestureDidChange:(UIPanGestureRecognizer *)gesture
                                          self.keyboardDidMoveBlock(newKeyboardViewFrameInView);
                                      */
                                  }
-                                 completion:^(BOOL finished){
-                                 }];
+                                 completion:nil];
             }
         }
             break;
@@ -475,7 +473,7 @@ - (void)panGestureDidChange:(UIPanGestureRecognizer *)gesture
                                      self.keyboardDidMoveBlock(newKeyboardViewFrameInView);
                                  */
                              }
-                             completion:^(BOOL finished){
+                             completion:^(__unused BOOL finished){
                                  [[self keyboardActiveView] setUserInteractionEnabled:!shouldRecede];
                                  if (shouldRecede)
                                  {