Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collapsible config option can cause orphaned nodes to not be displayed #129

Closed
sammaniamsam opened this issue Oct 11, 2018 · 2 comments 路 Fixed by #154
Labels

Comments

@sammaniamsam
Copy link

@sammaniamsam sammaniamsam commented Oct 11, 2018

From the docs :

@param {boolean} [collapsible=false] - 馃殔馃殔馃殔 Allow leaf neighbours nodes to be collapsed (folded), this will allow users to clear the way out and focus on the parts of the graph that really matter.

This option should not collapse disconnected nodes (orphaned nodes) by default. Right now, it does. This has been tested using the latest master branch.

danielcaldas added a commit that referenced this issue Oct 15, 2018
* Add marker component

* Add marker.const

* Render markers at graph level

* Create marker.helper. Replace arrowId for markerId naming

* Memoize operations to fetch marker id

* Add markers only in directed graphs

* Add size constatns to marker.const

* Memoize defs for markers

* Documentation for marker.helper

* Fix regression in graph.helper on link.types

* Update several tests and revert graph.config changes

* Fix comment on sandbox node click

* Add collapse.helper.js

* Properly config eslint for jest

* Fix sandbox no initial config provided

* Correct collapsible behavior for directed graphs with isNodeVisible

* Add @memberof for collapse.helper

* Pass click node handler as setState callback

* Clean collapse code in Graph component and graph.heler

* Add marker snapshot tests

* Add marker.helper tests

* Remove FIXME on sandbox resolved with initial config fix

* Small detail valid jsdoc for _tick

* Fix state transition between active/inactive collapsible config

* Fix bad call to toggleLinksMatrixConnections in Graph.jsx

* Differ condition to check leaf node for directed graphs

* Add eslint-plugin-cypress

* Add 'directed' to sandbox.po whitelist of checkboxes

* Add marker className to marker component

* Add e2e tests for directed graph

* Small lint fix

* Fix scenario for toggling directed config

* Add note in graph.config about issue #129

* Improvements in collapse.helper

* Write more unit tests for toggleLinksConnections

* Add module to eslint globals

* Support fullscreen query param on sandbox

* Add marvel dataset to sandbox

* Add jsdoc for directed config

* Code review
@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Oct 15, 2018

A possible strategy to fix this issue would be to tag orphan nodes when initializing graph state, this could be tricky tough since initialization can re-occur along the way in the same graph lifecycle... This needs to be planned carefully, thanks for reporting.

zvolchak added a commit to zvolchak/react-d3-graph that referenced this issue Oct 29, 2018
* Add marker component

* Add marker.const

* Render markers at graph level

* Create marker.helper. Replace arrowId for markerId naming

* Memoize operations to fetch marker id

* Add markers only in directed graphs

* Add size constatns to marker.const

* Memoize defs for markers

* Documentation for marker.helper

* Fix regression in graph.helper on link.types

* Update several tests and revert graph.config changes

* Fix comment on sandbox node click

* Add collapse.helper.js

* Properly config eslint for jest

* Fix sandbox no initial config provided

* Correct collapsible behavior for directed graphs with isNodeVisible

* Add @memberof for collapse.helper

* Pass click node handler as setState callback

* Clean collapse code in Graph component and graph.heler

* Add marker snapshot tests

* Add marker.helper tests

* Remove FIXME on sandbox resolved with initial config fix

* Small detail valid jsdoc for _tick

* Fix state transition between active/inactive collapsible config

* Fix bad call to toggleLinksMatrixConnections in Graph.jsx

* Differ condition to check leaf node for directed graphs

* Add eslint-plugin-cypress

* Add 'directed' to sandbox.po whitelist of checkboxes

* Add marker className to marker component

* Add e2e tests for directed graph

* Small lint fix

* Fix scenario for toggling directed config

* Add note in graph.config about issue danielcaldas#129

* Improvements in collapse.helper

* Write more unit tests for toggleLinksConnections

* Add module to eslint globals

* Support fullscreen query param on sandbox

* Add marvel dataset to sandbox

* Add jsdoc for directed config

* Code review
@stale stale bot added the wontfix label Nov 24, 2018
@stale stale bot closed this Dec 14, 2018
@danielcaldas danielcaldas added in progress and removed wontfix labels Dec 17, 2018
Repository owner deleted a comment from stale bot Dec 17, 2018
@danielcaldas danielcaldas reopened this Dec 17, 2018
@danielcaldas

This comment has been minimized.

Copy link
Owner

@danielcaldas danielcaldas commented Dec 19, 2018

Closing this with #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can鈥檛 perform that action at this time.