Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/directional graph #132

Merged
merged 40 commits into from
Oct 15, 2018
Merged

Feature/directional graph #132

merged 40 commits into from
Oct 15, 2018

Conversation

danielcaldas
Copy link
Owner

@danielcaldas danielcaldas commented Oct 14, 2018 •
edited
Loading

The long-awaited directional graph support!

#88

Out of scope changes:

  • Refactor in graph.helper.js move new collapsible logic into collapse.helper.js
  • eslint project config improvements (to follow up the cypress eslint configuration)
  • Small fix on Sandbox.jsx where initial config was not being provided property initially
  • Support fullscreen query parameter on live sandbox

TODOS:

  • Documentation - add GIF in directed section
  • Documentation - add new data sample with directed graphs on Sandbox

@danielcaldas
Add marker component
38a9259
@danielcaldas
Add marker.const
02e683c
@danielcaldas
Render markers at graph level
3b9aae5
@danielcaldas
Create marker.helper. Replace arrowId for markerId naming
83c6bc5
@danielcaldas
Memoize operations to fetch marker id
4eb1fa2
@danielcaldas
Add markers only in directed graphs
d66b183
@danielcaldas
Add size constatns to marker.const
28b80c7
@danielcaldas
Memoize defs for markers
dd367e5
@danielcaldas
Documentation for marker.helper
d9b0225
@danielcaldas
Fix regression in graph.helper on link.types
d58338d
@danielcaldas
Update several tests and revert graph.config changes
3359672
@danielcaldas
Fix comment on sandbox node click
6a1f388
@danielcaldas
Add collapse.helper.js
7389634
@danielcaldas
Properly config eslint for jest
0f9c686
@danielcaldas
Fix sandbox no initial config provided
73c6c78
@danielcaldas
Correct collapsible behavior for directed graphs with isNodeVisible
5a6c3c8
@danielcaldas
Add @memberof for collapse.helper
28c776f
@danielcaldas
Pass click node handler as setState callback
da96126
@danielcaldas
Clean collapse code in Graph component and graph.heler
7ee7b53
@danielcaldas
Add marker snapshot tests
cf69091
@danielcaldas
Add marker.helper tests
479e3d0
@danielcaldas
Remove FIXME on sandbox resolved with initial config fix
8352c02
@danielcaldas
Small detail valid jsdoc for _tick
f433275
@danielcaldas
Fix state transition between active/inactive collapsible config
c9fa9b4
@danielcaldas
Fix bad call to toggleLinksMatrixConnections in Graph.jsx
34e68fe
@danielcaldas
Differ condition to check leaf node for directed graphs
bcff7ca
@danielcaldas
Add eslint-plugin-cypress
d00daa9
@danielcaldas
Add 'directed' to sandbox.po whitelist of checkboxes
c935305
@danielcaldas
Add marker className to marker component
92f7ca2
@danielcaldas
Add e2e tests for directed graph
a06f46c
danielcaldas
danielcaldas commented Oct 14, 2018
View reviewed changes
Copy link
Owner Author

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1st code review

cypress/integration/graph.directed.e2e.js Show resolved Hide resolved
cypress/integration/graph.directed.e2e.js Show resolved Hide resolved
cypress/integration/graph.directed.e2e.js Outdated Show resolved Hide resolved
src/components/graph/Graph.jsx Outdated Show resolved Hide resolved
src/components/graph/collapse.helper.js Outdated Show resolved Hide resolved
src/components/graph/graph.config.js Outdated Show resolved Hide resolved
src/components/graph/graph.helper.js Outdated Show resolved Hide resolved
src/components/graph/graph.renderer.jsx Outdated Show resolved Hide resolved
src/components/graph/graph.renderer.jsx Outdated Show resolved Hide resolved
src/components/marker/marker.const.js Outdated Show resolved Hide resolved
@danielcaldas danielcaldas merged commit 765b8ae into master Oct 15, 2018
@danielcaldas danielcaldas mentioned this pull request Oct 16, 2018
Closed
@jcapobianco1
Copy link

Hi @danielcaldas thanks for this extremely useful feature! Is it available in version 2.0.0-rc1?

@danielcaldas
Copy link
Owner Author

Hey there @jcapobianco-cbi it's not yet available in 2.0.0-rc1 it will be available on the next rc or possible the 2.0.0. This should happen in the following days

@danielcaldas danielcaldas deleted the feature/directional-graph branch December 22, 2018 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danielcaldas @jcapobianco1