Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Feature/directional graph #132
The long-awaited directional graph support!
Out of scope changes:
zvolchak added a commit to zvolchak/react-d3-graph that referenced this pull request
Oct 29, 2018
* Add marker component * Add marker.const * Render markers at graph level * Create marker.helper. Replace arrowId for markerId naming * Memoize operations to fetch marker id * Add markers only in directed graphs * Add size constatns to marker.const * Memoize defs for markers * Documentation for marker.helper * Fix regression in graph.helper on link.types * Update several tests and revert graph.config changes * Fix comment on sandbox node click * Add collapse.helper.js * Properly config eslint for jest * Fix sandbox no initial config provided * Correct collapsible behavior for directed graphs with isNodeVisible * Add @memberof for collapse.helper * Pass click node handler as setState callback * Clean collapse code in Graph component and graph.heler * Add marker snapshot tests * Add marker.helper tests * Remove FIXME on sandbox resolved with initial config fix * Small detail valid jsdoc for _tick * Fix state transition between active/inactive collapsible config * Fix bad call to toggleLinksMatrixConnections in Graph.jsx * Differ condition to check leaf node for directed graphs * Add eslint-plugin-cypress * Add 'directed' to sandbox.po whitelist of checkboxes * Add marker className to marker component * Add e2e tests for directed graph * Small lint fix * Fix scenario for toggling directed config * Add note in graph.config about issue danielcaldas#129 * Improvements in collapse.helper * Write more unit tests for toggleLinksConnections * Add module to eslint globals * Support fullscreen query param on sandbox * Add marvel dataset to sandbox * Add jsdoc for directed config * Code review
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments.