Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/directional graph #132

Merged
merged 40 commits into from Oct 15, 2018

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented Oct 14, 2018

The long-awaited directional graph support!

#88

Out of scope changes:

  • Refactor in graph.helper.js move new collapsible logic into collapse.helper.js
  • eslint project config improvements (to follow up the cypress eslint configuration)
  • Small fix on Sandbox.jsx where initial config was not being provided property initially
  • Support fullscreen query parameter on live sandbox

TODOS:

  • Documentation - add GIF in directed section
  • Documentation - add new data sample with directed graphs on Sandbox
Copy link
Owner Author

danielcaldas left a comment

1st code review

cypress/integration/graph.directed.e2e.js Outdated Show resolved Hide resolved
src/components/graph/Graph.jsx Outdated Show resolved Hide resolved
src/components/graph/collapse.helper.js Outdated Show resolved Hide resolved
src/components/graph/graph.config.js Outdated Show resolved Hide resolved
src/components/graph/graph.helper.js Outdated Show resolved Hide resolved
src/components/graph/graph.renderer.jsx Outdated Show resolved Hide resolved
src/components/graph/graph.renderer.jsx Outdated Show resolved Hide resolved
src/components/marker/marker.const.js Outdated Show resolved Hide resolved
@danielcaldas danielcaldas merged commit 765b8ae into master Oct 15, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
zvolchak added a commit to zvolchak/react-d3-graph that referenced this pull request Oct 29, 2018
* Add marker component

* Add marker.const

* Render markers at graph level

* Create marker.helper. Replace arrowId for markerId naming

* Memoize operations to fetch marker id

* Add markers only in directed graphs

* Add size constatns to marker.const

* Memoize defs for markers

* Documentation for marker.helper

* Fix regression in graph.helper on link.types

* Update several tests and revert graph.config changes

* Fix comment on sandbox node click

* Add collapse.helper.js

* Properly config eslint for jest

* Fix sandbox no initial config provided

* Correct collapsible behavior for directed graphs with isNodeVisible

* Add @memberof for collapse.helper

* Pass click node handler as setState callback

* Clean collapse code in Graph component and graph.heler

* Add marker snapshot tests

* Add marker.helper tests

* Remove FIXME on sandbox resolved with initial config fix

* Small detail valid jsdoc for _tick

* Fix state transition between active/inactive collapsible config

* Fix bad call to toggleLinksMatrixConnections in Graph.jsx

* Differ condition to check leaf node for directed graphs

* Add eslint-plugin-cypress

* Add 'directed' to sandbox.po whitelist of checkboxes

* Add marker className to marker component

* Add e2e tests for directed graph

* Small lint fix

* Fix scenario for toggling directed config

* Add note in graph.config about issue danielcaldas#129

* Improvements in collapse.helper

* Write more unit tests for toggleLinksConnections

* Add module to eslint globals

* Support fullscreen query param on sandbox

* Add marvel dataset to sandbox

* Add jsdoc for directed config

* Code review
@jcapobianco-cbi

This comment has been minimized.

Copy link

jcapobianco-cbi commented Nov 5, 2018

Hi @danielcaldas thanks for this extremely useful feature! Is it available in version 2.0.0-rc1?

@danielcaldas

This comment has been minimized.

Copy link
Owner Author

danielcaldas commented Nov 8, 2018

Hey there @jcapobianco-cbi it's not yet available in 2.0.0-rc1 it will be available on the next rc or possible the 2.0.0. This should happen in the following days

@danielcaldas danielcaldas deleted the feature/directional-graph branch Dec 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.