Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular resolution of node and link parameters #166

Merged
merged 7 commits into from
Jan 25, 2019

Conversation

sauln
Copy link
Contributor

@sauln sauln commented Jan 17, 2019

This PR adds node level configuration of opacity and strokeWidth and link level configuration of opacity.

Also, it adds a prepare script so the library can be installed directly from GitHub. I can remove this if you'd like.

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job @sauln! Just some minor comments and it's good to merge! 🙌

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/graph/graph.builder.js Show resolved Hide resolved
@danielcaldas
Copy link
Owner

General comment, please change the title of this PR to More granular resolution of node and link parameters

@sauln sauln changed the title Finer resolution of node and link parameters More granular resolution of node and link parameters Jan 22, 2019
Nathaniel Saul added 2 commits January 21, 2019 20:51
- revert version bump
- set default strokeWidth to SAME
- add link level resolution to strokeWidth (for issue 149)
@sauln
Copy link
Contributor Author

sauln commented Jan 22, 2019

Updates include:

Copy link
Owner

@danielcaldas danielcaldas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@danielcaldas danielcaldas merged commit 0832e5f into danielcaldas:master Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants