Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More granular resolution of node and link parameters #166

Merged
merged 7 commits into from Jan 25, 2019

Conversation

@sauln
Copy link
Contributor

sauln commented Jan 17, 2019

This PR adds node level configuration of opacity and strokeWidth and link level configuration of opacity.

Also, it adds a prepare script so the library can be installed directly from GitHub. I can remove this if you'd like.

@sauln sauln force-pushed the sauln:master branch from 75d7746 to d8dda75 Jan 17, 2019
@sauln sauln force-pushed the sauln:master branch from d8dda75 to 4e55854 Jan 17, 2019
Copy link
Owner

danielcaldas left a comment

Nice job @sauln! Just some minor comments and it's good to merge! 🙌

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
src/components/graph/graph.builder.js Show resolved Hide resolved
@danielcaldas

This comment has been minimized.

Copy link
Owner

danielcaldas commented Jan 20, 2019

General comment, please change the title of this PR to More granular resolution of node and link parameters

@sauln sauln changed the title Finer resolution of node and link parameters More granular resolution of node and link parameters Jan 22, 2019
sauln added 2 commits Jan 22, 2019
- revert version bump
- set default strokeWidth to SAME
- add link level resolution to strokeWidth (for issue 149)
@sauln

This comment has been minimized.

Copy link
Contributor Author

sauln commented Jan 22, 2019

Updates include:

  • Title changed
  • include fix for #149
  • version fixed
  • node.strokeWidth default changed to SAME w/ documentation
  • continuing conversation about prepare
Copy link
Owner

danielcaldas left a comment

Awesome!

@danielcaldas danielcaldas merged commit 0832e5f into danielcaldas:master Jan 25, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.