Fixing graph reset #377
Merged
Fixing graph reset #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielcaldas
requested changes
Oct 7, 2020
antoninklopp
force-pushed
the
fix/graph-reset
branch
from
a83aada
to
2131ea0
Compare
danielcaldas
added
the
hacktoberfest-accepted
danielcaldas
approved these changes
Oct 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #372 .
However, when the graph is reset, it now replays the force animation from the graph beginning (when you open it for the first time).
We could maybe avoid this by checking some properties leading to a graph with forces or without (for example static graphs). We could also consider that it is normal that during a reset, the graph replays this shrinking animation.
What do you think @danielcaldas ?