You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At a first glance, there's seems to be something off with the implementation of resetNodesPositions. Initially, it was meant to not allow "reset" for static graphs, as we can clearly see by the if statement. But later on, we did not follow up with the staticGraphWithDragAndDrop property 🤔 . If someone if trying to look into this issue try to debug with the following:
Understand how resetNodesPositions can be used from the client, make sure you can replicate the issues that @antoninklopp mentions in the issue description.
Try to understand why is that the code, does not have an effect in the sandbox 2:
I have a strong feeling that the issue might be around graph.helper.js in the function _initializeNodes(graphNodes) where we're looking into the properties fx and fy of node. But this is just a theory as of right now, I didn't have the time to look into this one yet, so if you're looking for a way to contribute, please go ahead, PRs are very welcome!
Describe the bug
Some properties make the graph becomes unresetable.
To Reproduce
Steps to reproduce the behaviour:
Expected behaviour
Given this code :
react-d3-graph/sandbox/Sandbox.jsx
Line 139 in 083bb5b
it would make sense that it resets any graph to its initial position especially for static graphs which are not reset either.
Environment:
The text was updated successfully, but these errors were encountered: