Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/provide svg for nodes #60

Merged
merged 11 commits into from Apr 1, 2018

Conversation

@danielcaldas
Copy link
Owner

danielcaldas commented Apr 1, 2018

This PR addresses issue: #36

This PR makes possible for rd3g clients to set a custom svg instead of simple d3 shapes.

  • New prop config.node.svg allows setting a global svg to render for all nodes
  • Also inside of data.nodes one can specify the svg prop to render that svg only for that specific node
  • ⭐️ To try this out in the sandbox just type ./sample.svg inside the node.svg text input, or add an url for some svg out there in the web
@danielcaldas danielcaldas merged commit 7cb98c7 into master Apr 1, 2018
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@danielcaldas danielcaldas deleted the feature/provide-svg-for-nodes branch Apr 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.