Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plugin crashes when using <includeCommitsAfter> #56

Closed
zwik opened this issue Jan 25, 2019 · 2 comments
Closed

plugin crashes when using <includeCommitsAfter> #56

zwik opened this issue Jan 25, 2019 · 2 comments

Comments

@zwik
Copy link
Contributor

zwik commented Jan 25, 2019

We run the latest version of the plugin 1.13.15 but it keeps crashing on new GIT repositories for us. Here's a part of what I think is the most important part of the stack of the crash:

Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
    at org.eclipse.jgit.revwalk.RevCommit.getParent (RevCommit.java:295)
    at com.github.danielflower.mavenplugins.gitlog.filters.PathCommitFilter.isFoundInPath (PathCommitFilter.java:48)
    at com.github.danielflower.mavenplugins.gitlog.filters.PathCommitFilter.renderCommit (PathCommitFilter.java:40)
    at com.github.danielflower.mavenplugins.gitlog.Generator.show (Generator.java:108)
    at com.github.danielflower.mavenplugins.gitlog.Generator.generate (Generator.java:82)
    at com.github.danielflower.mavenplugins.gitlog.GenerateMojo.execute (GenerateMojo.java:348)

You can see that it actually crashes in the jgit plugin. I've been looking into the POM and it seems the plugin is using an older version of the jgit plugin... Not even the original Eclipse one. Should this be bumped to a newer version?

@zwik
Copy link
Contributor Author

zwik commented Jan 25, 2019

It wasn't the issue. If no parent commit can be found it can be crashed. I'll create a pull request.

danielflower added a commit that referenced this issue Jan 27, 2019
Fix #56. When there's no parent commit, don't fail
@danielflower
Copy link
Owner

Release version is 1.13.16 - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants