Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various Fixes #15

Closed
wants to merge 4 commits into from
Closed

Various Fixes #15

wants to merge 4 commits into from

Conversation

Yogpod
Copy link

@Yogpod Yogpod commented Jan 6, 2023

Include has a return value

Include has a return value
@Yogpod
Copy link
Author

Yogpod commented Jan 6, 2023

also to fix #11 I just added this to sv_core

luapack.AddCSLuaFile("derma/init.lua")
luapack.AddCSLuaFile("skins/default.lua")

@Yogpod
Copy link
Author

Yogpod commented Jan 6, 2023

and also you can probably remove the dependency of the crypt module and swap it for gmod functions because of this being in gmod now

@danielga danielga self-requested a review January 6, 2023 18:26
@danielga danielga self-assigned this Jan 6, 2023
Remove gm_crypt requirement
Forgot to change this
@YuriNeverov
Copy link

This solved issue for me, thanks

@Yogpod
Copy link
Author

Yogpod commented Jun 22, 2023

your game will crash if your cl_downloadfilter prevents the .dat file from downloading, gluapack avoids this by writing as a .bsp file

@Yogpod Yogpod changed the title Update cl_overrides.lua Various Fixes Jun 22, 2023
@YuriNeverov
Copy link

your game will crash if your cl_downloadfilter prevents the .dat file from downloading, gluapack avoids this by writing as a .bsp file

Is there a simple way to modify this luapack to use .bsp?

As far as I understand, FastDL will not help to send .dat file, but will help to send .bsp file. And I don't see point of collecting luas in one big .dat file if it will be sent with same speed as usual .lua files. (Although maybe there is some speed gain due to compression and sending one file instead of many, but it still is sent with very small limit on speed (about several KB/s if I'm not mistaken)

@YuriNeverov
Copy link

Is there a simple way to modify this luapack to use .bsp?

danielga/gmsv_luapack_internal#11

https://github.com/Yogpod/luapack/blob/f7b69b71ccae63651c63a71b25aa0bdaa02a2233/lua/luapack/sv_core.lua#L252 .dat -> .bsp

https://github.com/Yogpod/luapack/blob/f7b69b71ccae63651c63a71b25aa0bdaa02a2233/lua/luapack/cl_core.lua#L95 .dat. -> .bsp

Wow, this really is a simple way XD

And one more question, can I place this file into another folder, for example, garrysmod/maps to store it into FastDL then and ensure fast sending speed?

@Yogpod
Copy link
Author

Yogpod commented Jun 22, 2023

possibly? no idea but it sounds likely

@YuriNeverov
Copy link

Thanks a lot! I will probably try it then, someday

@Yogpod
Copy link
Author

Yogpod commented Jun 24, 2023

oops i should have looked at the develop branch, only thing that isnt there from here is the gm_crypt requirement removal

@Yogpod Yogpod closed this Jun 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants