Skip to content
This repository has been archived by the owner on Mar 11, 2024. It is now read-only.

🐛 fix missing pyarrow.dataset import for pyarrow 13.0.0 #38

Merged
merged 3 commits into from
Oct 31, 2023

Conversation

seandavi
Copy link
Contributor

This is an attempt to fix #37.

This is an attempt to fix danielgafni#37.
danielgafni
danielgafni previously approved these changes Oct 27, 2023
Copy link
Owner

@danielgafni danielgafni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey! Thanks for the PR.
What pyarrow version are you on?

@seandavi
Copy link
Contributor Author

pyarrow 13.0.0

@danielgafni
Copy link
Owner

danielgafni commented Oct 27, 2023

Thanks.

Also, any idea why doesn't CI show up?
There should be a section for "Workflow(s) awaiting approval", but it's not available.
Perhaps you need to request it?

@danielgafni danielgafni changed the title Fix missing import 🐛 missing pyarrow.dataset import for pyarrow 13.0.0 Oct 27, 2023
@danielgafni danielgafni changed the title 🐛 missing pyarrow.dataset import for pyarrow 13.0.0 🐛 fix missing pyarrow.dataset import for pyarrow 13.0.0 Oct 27, 2023
@danielgafni
Copy link
Owner

danielgafni commented Oct 31, 2023

hey @seandavi , would you be able to run poetry run pre-commit install and poetry run pre-commit run -a in order to fix some minor formatting issues?

@danielgafni
Copy link
Owner

not sure why is there no CI.. anyway, I'll merge. Thanks!

@danielgafni danielgafni merged commit 293b7d6 into danielgafni:master Oct 31, 2023
1 check passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pyarrow has no attribute dataset
2 participants