unnecessary print statement removed #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unnecessary print statement removed
|
the style test is failing, you need to run this file to fix the problems https://github.com/danielhrisca/asammdf/blob/development/run_black_and_ruff.bat |
|
Sorry for the delay (and using the master branch) but now I added the changes from running the style checks in development/run_black_and_ruff.bat |
|
Not really sure how to proceed here. Style checks fail because of but ruff doesn't pick up on that when I run locally. I'll remove that import manually. Regarding the general tests which fails on Ubuntu and Windows in test_PushButton_CreateWindow and test_Plot_ChannelSelection_DragAndDrop_fromPlot_toPlot, I don't see how that is related to my PR. |
|
Style should be fixed now |
danielhrisca
approved these changes
Dec 18, 2023
danielhrisca
merged commit 28ba926
into
danielhrisca:development
10 of 17 checks passed
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This print statement seems unnecessary. It originates from 4e2b2d2 but I cant't see the purpose. Could it just be removed?
For me it started to appear just now that I changed my Python environment. Everytime I run Signal.plot I get an error printed (no actual error, just the traceback printed) because the call to gui.plot 4 lines above the print raises an Exception since importing PySide6 fails in my environment. But Signal.plot produces a plot, so no need to show an error I guess.