Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove #ifdefs from phantom #55

Open
danieljprice opened this issue Aug 18, 2020 · 1 comment
Open

remove #ifdefs from phantom #55

danieljprice opened this issue Aug 18, 2020 · 1 comment

Comments

@danieljprice
Copy link
Owner

#ifdefs look horrible in the code, and make testing all possible compile-time combinations very difficult. We should avoid introducing any new #ifdefs, preferencing use of the logical flags from the config module where possible, e.g. if (mhd), if (radiation) etc.

Many of these could also be made into runtime options, since they are mainly there to determine whether memory is allocated for certain arrays. This would need a bit more thought.

For now, we should try to keep as many files as .f90 as possible, rather than .F90, to disallow the use of ugly and unnecessary #ifdef statements. The only allowed use case for #ifdefs should be for linking with external libraries, e.g. MPI, or when the performance really matters (e.g. use of #ifdef PERIODIC in dens, force or kdtree)
@danieljprice danieljprice mentioned this issue Aug 26, 2020
Merged
danieljprice added a commit that referenced this issue Aug 27, 2020
@danieljprice
(#55) .F90->.f90 for files already clear of #ifdefs, to disallow rein…
a976fff 
…troduction
danieljprice added a commit that referenced this issue Sep 11, 2020
@danieljprice
(test_radiation) remove ifdefs from .f90 file #55
d221a47
danieljprice added a commit that referenced this issue Oct 1, 2020
@danieljprice
(test_gravity) cleanup of routine, split into subroutines, remove ifd…
2ebf31d 
…efs #55
danieljprice added a commit that referenced this issue Jul 28, 2021
@danieljprice
(#55) remove MCFOST ifdefs from setup_disc.F90
0cbd14d
danieljprice added a commit that referenced this issue Jul 28, 2021
@danieljprice
(#55) setup_disc.F90->setup_disc.f90
530e593
danieljprice added a commit that referenced this issue Nov 28, 2021
@danieljprice
(test_ptmass; #55) no preprocessing, rename to .f90
80c0d1f
@dliptai dliptai mentioned this issue Mar 3, 2022
Merged
@danieljprice danieljprice mentioned this issue May 2, 2022
Merged
danieljprice added a commit that referenced this issue Jun 6, 2022
@danieljprice
(setup) can now give --maxp=1e7 flag to phantomsetup instead of compi…
02a008f 
…ling with MAXP= which is now obsolete (#55)
danieljprice added a commit that referenced this issue Aug 10, 2022
@danieljprice
(sink_radiation; nucleation) cleanup of unused code, use eos_vars to …
ef90f24 
…get temperature instead of calling get_temperature; remove ifdefs in derivs (#55)
@lsiess lsiess mentioned this issue Aug 10, 2022
Merged
danieljprice added a commit to Fitz-Hu/phantom that referenced this issue Sep 9, 2022
@danieljprice
(gr) BUG FIX in conductivity w/Minkowski metric; use beta in viscosit…
31d14d6 
…y; simplify slope limiter; remove ifdefs (danieljprice#55)
s-neilson pushed a commit to s-neilson/phantom that referenced this issue Mar 18, 2023
@danieljprice
(setup) can now give --maxp=1e7 flag to phantomsetup instead of compi…
a5e735b 
…ling with MAXP= which is now obsolete (danieljprice#55)
s-neilson pushed a commit to s-neilson/phantom that referenced this issue Mar 18, 2023
@danieljprice
(sink_radiation; nucleation) cleanup of unused code, use eos_vars to …
e979dd1 
…get temperature instead of calling get_temperature; remove ifdefs in derivs (danieljprice#55)
s-neilson pushed a commit to s-neilson/phantom that referenced this issue Mar 18, 2023
@danieljprice
(gr) BUG FIX in conductivity w/Minkowski metric; use beta in viscosit…
5138894 
…y; simplify slope limiter; remove ifdefs (danieljprice#55)
danieljprice added a commit that referenced this issue Mar 22, 2023
@danieljprice
(#349,#55) remove ifdefs, use ind_timesteps flag instead, fixes compi…
f28e853 
…ler warnings
danieljprice added a commit that referenced this issue Mar 23, 2023
@danieljprice
(#349,#55) compiler warnings fixed in forcing.F90; remove STIR_FROM_F…
6d799bf 
…ILE ifdef and made it runtime option
danieljprice added a commit that referenced this issue Mar 23, 2023
@danieljprice
(#349,#55) compiler warnings fixed in forcing.F90; remove STIR_FROM_F…
8444430 
…ILE ifdef and made it runtime option
danieljprice added a commit that referenced this issue Mar 23, 2023
@danieljprice
(#349,#55) remove ifdef GR and KROME from eos module; fix compiler wa…
bfda6f3 
…rnings
danieljprice added a commit that referenced this issue Mar 23, 2023
@danieljprice
(#349, #55) compiler warnings fixed; remove ifdefs from test_dust
3cfbfe7
danieljprice added a commit that referenced this issue Mar 23, 2023
@danieljprice
(wind; #349; #55) fix compiler warnings; move utility routines into u…
ca62f3c 
…tils_tables.f90; added isothermal logical flag; add set_default_parameters routine to setup_wind.F90
danieljprice added a commit that referenced this issue Mar 24, 2023
@danieljprice
(#349, #55) remove ifdef IND_TIMESTEPS from step; replace with if (in…
34254a7 
…d_timesteps)
danieljprice added a commit that referenced this issue Mar 24, 2023
@danieljprice
(#55) remove FINVSQRT ifdefs from externalforces; use get_G_code() wh…
a2f1519 
…ere needed
danieljprice added a commit that referenced this issue Mar 24, 2023
@danieljprice
(#55) remove FINVSQRT ifdefs from externalforces; use get_G_code() wh…
d9575eb 
…ere needed
danieljprice added a commit that referenced this issue May 8, 2023
@danieljprice
(build; #55) remove obsolete #ifdef KERR
717fd45
danieljprice added a commit that referenced this issue May 12, 2023
@danieljprice
(bondi) setup failures with DEBUG=yes fixed; remove ifdefs #55
ec052ca
danieljprice added a commit that referenced this issue May 12, 2023
@danieljprice
(readwrite_infile) #55 remove ifdefs; minor changes to wording
e609998
danieljprice added a commit that referenced this issue Jun 14, 2023
@danieljprice
(#435; #55) use lower resolution in dust growth tests; remove ifdefs
4693d80
danieljprice added a commit that referenced this issue Jun 16, 2023
@danieljprice
(#55) renamed .F90 files without #ifdef statements to .f90
82ce32f
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(testparticles; #55) remove ifdefs
26cd79e
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#450, #55) remove unused/obsolete -DDEBUG flag
890c401
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(wind; #55; #450) remove #ifdefs; remove spurious extra line in injec…
f2565cd 
…tion options
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(readwrite_dumps; #55) remove ifdefs
22d3e95
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(growth; #55) remove ifdefs
2f6a801
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#450; #55) fix issue with SETUP=testkd; initialise radiation arrays;…
7a583c9 
… allow timestep too small to at least get to writing a dump file
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#55) bug fix in readwrite_infile
e6319d5
@danieljprice danieljprice mentioned this issue Jul 10, 2023
Merged
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#450; #55) fix issues in readwrite_dumps with ifort and DEBUG=yes
b14e87c
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#450; #55) compiler warning/ bug fixed
4983096
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#55) remove krome ifdefs in readwrite_dumps
ada5571
danieljprice added a commit that referenced this issue Jul 10, 2023
@danieljprice
(#450; #55) build failures fixed
a6f0d8b
danieljprice added a commit that referenced this issue Jul 12, 2023
@danieljprice
(mpi; #450; #55) bug fix with particle buffer size not matching: simp…
0df13d6 
…lified code for this
danieljprice added a commit that referenced this issue Jul 12, 2023
@danieljprice
(mpi) bug fix/disable test_wind with mpi, remove ifdefs (#55)
7ba4a8a
danieljprice added a commit that referenced this issue Jul 14, 2023
@danieljprice
(#55) remove WIND=yes as #ifdef WIND no longer exists; use DUST_NUCLE…
24af154 
…ATION=yes/no and INJECT_PARTICLES=yes/no
@danieljprice danieljprice mentioned this issue Oct 26, 2023
Merged
danieljprice added a commit that referenced this issue Nov 27, 2023
@danieljprice
(test_sedov; #55) remove ifdefs
3caee7a
danieljprice added a commit that referenced this issue Nov 27, 2023
@danieljprice
(step; #55) remove GR ifdef from step, always compile extern_gr.F90
426a728
@danieljprice danieljprice mentioned this issue Dec 15, 2023
Closed
@danieljprice danieljprice mentioned this issue Apr 3, 2024
Merged
danieljprice added a commit that referenced this issue Apr 9, 2024
@danieljprice
(#55) .F90->.f90 for dust subroutines with no ifdefs
b6336f9
danieljprice added a commit that referenced this issue Apr 9, 2024
@danieljprice
(#55) .F90->.f90 for modules where ifdefs have been successfully removed
28bfcf3
danieljprice added a commit that referenced this issue Apr 9, 2024
@danieljprice
(#55) more .F90->.f90 and minor cleanups
bc0f007
danieljprice added a commit that referenced this issue Apr 9, 2024
@danieljprice
(porosity) #55 remove spurious ifdef PHOTO/obsolete functionality; re…
81bda36 
…store changes which should not differ from master branch
danieljprice added a commit that referenced this issue Apr 10, 2024
@danieljprice
(rwdumps) fix numbering of errors in write_array calls; just use a cu…
4a5791c 
…mulative error count; remove obsolete ifdef #55
danieljprice added a commit that referenced this issue Apr 10, 2024
@danieljprice
(readwrite_dumps) cleanup: remove ifdefs #55 and move helper routines…
4902d96 
… into utility modules
danieljprice added a commit that referenced this issue Apr 10, 2024
@danieljprice
#55 .F90->.f90
63bd130
danieljprice added a commit that referenced this issue Apr 18, 2024
@danieljprice
(test_derivs) cleanup ifdefs #55 and fix bug with mask, resolves #529
fca8bec
@danieljprice danieljprice mentioned this issue Apr 18, 2024
Merged
@danieljprice
Copy link
Owner Author

Current status:

Number of source files (.f90, .F90):      442
Number of .f90 files               :      380
Number of .F90 files               :       62
Number of unique #ifdef statements :       48
Number of total  #ifdef statements :      526

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@danieljprice