-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Automated test that ./phantom blah.in succeeds after running phantomsetup #451
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eptions fixed, remove ifdefs
The problem with the test setups is that you have to compile and link with
and the use of
but I am sure you will find a more elegant way of doing it. |
got it, I think I fixed this bit at least |
…on before any particles have been injected
…ATION=yes/no and INJECT_PARTICLES=yes/no
…=.false. causing problems reading header)
…ullen-Dehnen switch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
Bug fix / new test
Description:
See #450 and #449: In the buildbot we now check not only that ./phantomsetup blah succeeds, but also that ./phantom blah.in successfully runs for at least one timestep
Testing:
Checked that this works with SETUP=turb, will be checked fully in the GitHub actions
UPDATE: a LOT of the setups turned out to be broken when run this way, particularly with DEBUG=yes. Slowly working through the backlog of complaints from the actions... tidying up a few other things (especially #55) as I go along
Did you run the bots? yes
Did you update relevant documentation in the docs directory? yes