Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automated test that ./phantom blah.in succeeds after running phantomsetup #451

Merged
merged 92 commits into from
Jul 14, 2023

Conversation

danieljprice
Copy link
Owner

@danieljprice danieljprice commented Jul 6, 2023

Type of PR:
Bug fix / new test

Description:
See #450 and #449: In the buildbot we now check not only that ./phantomsetup blah succeeds, but also that ./phantom blah.in successfully runs for at least one timestep

Testing:
Checked that this works with SETUP=turb, will be checked fully in the GitHub actions

UPDATE: a LOT of the setups turned out to be broken when run this way, particularly with DEBUG=yes. Slowly working through the backlog of complaints from the actions... tidying up a few other things (especially #55) as I go along

Did you run the bots? yes

Did you update relevant documentation in the docs directory? yes

lsiess and others added 30 commits July 4, 2023 18:08
…unch more #ifdefs; delete obsolete utherm/etherm_from_u functionality
@lsiess
Copy link
Contributor

lsiess commented Jul 11, 2023

The problem with the test setups is that you have to compile and link with utils_binary.f90 set_binary.f90 inject_wind.f90 because they are needed for test_wind. I found a dirty way of doing it in the Makefile with

ifndef SRCINJECT
    SRCINJECT=utils_binary.f90 set_binary.f90 inject_wind.f90
endif

and the use of

INJECT_PARTICLES=yes

but I am sure you will find a more elegant way of doing it.
cheers

@danieljprice
Copy link
Owner Author

got it, I think I fixed this bit at least

@danieljprice danieljprice merged commit 4df45e5 into master Jul 14, 2023
177 checks passed
@danieljprice danieljprice deleted the setup-test branch July 14, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants