setup for tidal disruption event in GR #413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…setting M=0 in metric
This was referenced May 9, 2023
…ation options to/from .setup file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
improved setup procedure
Description:
Cleanup of the setup procedure for tidal disruption events in General Relativity. Previously this required compiling with SETUP=grstar and then moddump using moddump_tidal.f90
Now, setup_grtde calls the new general set_star procedure to setup and relax a star. To avoid the need to switch metrics we simply set M=0 in the Kerr or Schwarzschild metric during relaxation, effectively giving a Minkowski metric during the stellar relaxation procedure
I also corrected an issue where we had set ireconav = 1 by default in the .in file for GR simulations, which is problematic if anything gets too close to the black hole. Hence the default setting is now ireconav=-1. This fixes #333
Testing:
1000 particle GR tidal disruption event with polytrope works out-of-the-box
Did you run the bots? yes
Did you update relevant documentation in the docs directory? not yet