restartable relaxation process for stars #414 #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hantomsetup is run again; added nice printout
danieljprice
changed the title
…ed by write_setupfile followed by read_setupfile on all MPI threads
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of PR:
enhanced functionality implementing #414
Description:
If phantomsetup is interrupted half way through a stellar relaxation, or did not fully converge, the process can be restarted by simply running phantomsetup again. Similarly, running phantomsetup will look for matching snapshots from previous relaxation runs and will not repeat the procedure if the star is already relaxed
This P-R also fixes a couple of memory allocation errors encountered when running phantomsetup with DEBUG=yes.
To prevent these from reoccurring phantomsetup is now always compiled with DEBUG=yes in the GitHub actions tests
this required a bunch of things to be fixed in a bunch of different setup routines
Testing:
running phantomsetup using SETUP=binary as described in the docs
Did you run the bots? yes
Did you update relevant documentation in the docs directory? yes