-
Notifications
You must be signed in to change notification settings - Fork 23.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved checker scripts #939
Conversation
66e0bb7
to
2d2d020
Compare
Here is the workflow running |
passed field looks abit wonky |
cb29ecf
to
fd1e370
Compare
Hey @molangning |
@g0tmi1k #963 has a commit that changed new line checker to be more lenient, but the recent commits that I did has already made it more lenient. Unfortunately, I can’t do anything on my side as resolving the conflict has to be done on your side. You should be able to merge my changes without any repercussions. There is a great guide by github on resolving merge conflicts through github web. |
Hi @molangning , I can't push to molangning/SecLists, as a result it needs to be addressed by yourself. Otherwise, I'll close the MR and you can re-open it later if you wish. |
Rebase time 🎉 |
The current new line checker is too "harsh" as it exists immediately when ran. Normally that is a non issue but having to repair and commit only for it fail is quite frustrating
The workflow now uses github actions summary and adds more details to the checks, letting the person who opened the pull request know what checks are failing and how to change them