Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved checker scripts #939

Closed
wants to merge 17 commits into from
Closed

Conversation

molangning
Copy link
Contributor

@molangning molangning commented Nov 26, 2023

The current new line checker is too "harsh" as it exists immediately when ran. Normally that is a non issue but having to repair and commit only for it fail is quite frustrating

The workflow now uses github actions summary and adds more details to the checks, letting the person who opened the pull request know what checks are failing and how to change them

@molangning molangning marked this pull request as draft November 26, 2023 14:22
@molangning molangning changed the title Changed checker to be more forgiving Improved checker scripts Nov 28, 2023
@molangning molangning marked this pull request as ready for review November 30, 2023 15:36
@molangning
Copy link
Contributor Author

molangning commented Nov 30, 2023

Here is the workflow running
https://github.com/molangning/SecLists/actions/runs/7048714772

Screenshot_2023-11-30_23-37-17

@molangning
Copy link
Contributor Author

passed field looks abit wonky

@molangning molangning force-pushed the patch-4 branch 2 times, most recently from cb29ecf to fd1e370 Compare December 1, 2023 01:36
@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Feb 13, 2024

Hey @molangning
There is now a merge conflict - would you be able to look into it?

@g0tmi1k g0tmi1k self-assigned this Feb 13, 2024
@g0tmi1k g0tmi1k added the bug Bug label Feb 13, 2024
@molangning
Copy link
Contributor Author

@g0tmi1k #963 has a commit that changed new line checker to be more lenient, but the recent commits that I did has already made it more lenient. Unfortunately, I can’t do anything on my side as resolving the conflict has to be done on your side. You should be able to merge my changes without any repercussions.

There is a great guide by github on resolving merge conflicts through github web.
https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/addressing-merge-conflicts/resolving-a-merge-conflict-on-github

@g0tmi1k
Copy link
Collaborator

g0tmi1k commented Feb 16, 2024

Hi @molangning , I can't push to molangning/SecLists, as a result it needs to be addressed by yourself.

Otherwise, I'll close the MR and you can re-open it later if you wish.

@molangning
Copy link
Contributor Author

Rebase time 🎉

@molangning molangning closed this Feb 16, 2024
@molangning molangning mentioned this pull request Feb 16, 2024
g0tmi1k added a commit that referenced this pull request Feb 17, 2024
@molangning molangning deleted the patch-4 branch February 19, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants