-
Notifications
You must be signed in to change notification settings - Fork 23.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add trace header to http-request-headers-fields-large.txt #963
Conversation
Fix the erroneous 'has an empty entry at line $file-line-length+1' error
#939 Is a improvement of the checker scripts but it hasn’t merged yet. Can I commit that fix instead? |
Looks like your pull still has the newline bug, using |
I’m still fixing it, would this suffice?
|
The purpose of the checker was to detect empty lines and new lines at the end of the files. |
You don't need the
|
There is a possible case where instead of an empty line there is a line with just whitespace.
the second element should be flagged as well because it just contains whitespace line.strip removes that whitespace so that |
Respectfully, I disagree here. A chain of whitespace of varying length is a valid fuzzing payload that I'd expect to exist in the fuzzing wordlists. |
I agree with you, and so that’s why it outputs a warning and not an error. It’s not a requirement but if there isn’t supposed to be a empty line in the list the author can catch it early before having it merged. Should I add another case where it warns about the whitespace? |
I added some more changes SecLists/.bin/checkers/new-line-and-empty-line-checker.py Lines 54 to 65 in 46b13d5
|
Thanks @denandz |
Adds the
X-Trace
header to the large header fields list.