Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MSCKF::marginalize wrong index in p_f_G_vec ? #23

Open
chanochh opened this issue Jun 5, 2019 · 0 comments
Open

MSCKF::marginalize wrong index in p_f_G_vec ? #23

chanochh opened this issue Jun 5, 2019 · 0 comments

Comments

@chanochh
Copy link

chanochh commented Jun 5, 2019

I saw an out of bounds crash while running in Debug mode.

In msckf.h line 419 assumes that feature_tracks_to_residualize_[iter]
corresponds to p_f_G_vec[iter]

However, the loop in line 352, which push_backs to p_f_G_vec
has a continue instruction in line 358, which skips the push_back,
So the this might be false

It also seems that p_f_G_vec is not needed at all, because line 370 saves the p_f_G inside
the track itself (if it is valid)

(current commit d51c9ee)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant