Documentation and logging fixes #48
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrubiolo
commented
Nov 2, 2020
|
|
||
| ```sh | ||
| $ make build | ||
| ... | ||
| $ $GOPATH/bin/terraform-provider-proxmox | ||
| $ ./bin/terraform-provider-proxmox |
There was a problem hiding this comment.
Despite me correctly setting GOPATH as per the doc, I never saw the binary ending under $GOPATH/bin. This is confirmed by looking at the Makefile itself which uses `go build -o "bin/ ..."
The debug mode now shows the full URL of the Proxmox API, as this helps debugging errors in the user configuration. Authentication requests are now also logged as well. Documentation has been improved to be clearer about assumptions made by the provider.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The debug mode now shows the full URL of the Proxmox API, as this helps
debugging errors in the user configuration. Authentication requests are
now also logged as well.
Documentation has been improved to be clearer about assumptions made by
the provider.
Community Note
Release note for CHANGELOG: