-
-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure a common cursor position after printing a sixel in direct mode #1747
Comments
Or possibly xterm leaves the cursor at the first column of the last line of the image? Perhaps it depends on where the sixel cursor ends up… And I have no idea what the VT340 did. |
and mlterm makes it visible, for unfathomable reasons! thanks for the heads-up, definitely a Notcurses job (if not a particularly exciting one). |
one thing i need go look at all subject terminals about is how they update the cursor (and for that matter draw the graphic) when in RTL orientation. IMHO, if you're going RTL, you ought draw your image RTL as well, and place the cursor to the left of it when done. i doubt this is done anywhere. if you're using Qudum Mongγol bičig and writing top to bottom, i assume you're accustomed to nothing working, ever. |
just as a note to myself, this doesn't matter in rendered mode, since we always do a hard cursor move there. you know, maybe we ought do the same thing in direct mode, which would allows us to remove the leaky abstraction plumbing this actually kinda sucks, though, because if alacritty is moving the cursor down below the graphic, they're also presumably scrolling if we blit to the last line. blargh. the issue here might be more one of alacritty not honoring 8452:
yeah, i kinda think that alacritty is failing to honor 8452 here. i'll file a bug against them. given that the sixel code still(!) has not been merged in alacritty, i don't see any need to put in code to differentiate and handle older versions of alacritty -- if we can get this fixed, it'll be present from day 1 of their sixel support. you agree with all this, @db48x? |
hrmmm, we get the same results in |
i intend to get to this soon, definitely in the 2.3.x cycle, but probably not within the next week. i'm considering it lower priority than some other things due to the existence of a workaround (unconditional postblit positioning of the cursor). if that's giving you any kind of problem, due perhaps to an inability to reliably determine the desired cursor position, please let me know and i'll bump up the priority. |
I made a merge request for Alacritty, so hopefully there will be few special cases. |
awesome |
i just posted "why haven't they merged your good shit yet?" in the alacritty issue, because i'm a goddamned moron, though my question still stands. this is currently breaking video playing with |
@db48x , just wanted to let you know that direct mode is likely to be weakly deprecated, in the sense that i'm not going to be putting effort into it going forward, and new code ought be written to use "cli mode". this latter is just the main Notcurses API together with some flags plus a scrolling standard plane. direct mode will continue to be supported through at least Notcurses IV. bugfixes like this will still happen where necessary. |
i think commit 34869d3 might have just resolved this. |
the behavior above no longer occurs in any emulator i can find to test with. i think we're good here now. |
It looks like xterm leaves the cursor at the last line of the image, one past the last column, while Alacritty leaves it on the first column of the line after the image.
It sure would be nice if notcurses abstracted this difference away. :)
The text was updated successfully, but these errors were encountered: