Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xterm ncplayer -k suffers fullscreen bouncing when used with non-pixel blitters #1820

Closed
dankamongmen opened this issue Jun 24, 2021 · 9 comments
Assignees
Labels
bug Something isn't working
Milestone

Comments

@dankamongmen
Copy link
Owner

See #1804 for background. It looks like ncplayer -k with XTerm causes bounces unless -bpixel is used.

@dankamongmen dankamongmen added the bug Something isn't working label Jun 24, 2021
@dankamongmen dankamongmen added this to the 3.0.0 milestone Jun 24, 2021
@dankamongmen dankamongmen self-assigned this Jun 24, 2021
@dankamongmen
Copy link
Owner Author

just about fixed. only problem now would seem to be that in all terminals, -k with a non-fullescreen video runs up to the top of the screen. this only happens with video, so it's presumably something in ncdirect_stream().

@dankamongmen
Copy link
Owner Author

this last was apparently also happening with 2.3.5 [shrug] [sigh].

@dankamongmen
Copy link
Owner Author

and 2.3.4. this has been happening for some time.

@dankamongmen
Copy link
Owner Author

is it possible this has never worked? surely not, right? i've tested this, i'm pretty certain.

@dankamongmen
Copy link
Owner Author

i guess i've never tested it from anywhere but the top? maybe? i don't think so, though...

@dankamongmen
Copy link
Owner Author

want to move the cursor up one less now that we stay on the same row where we printed, unless we filled the row, in which case we move it up the full expected amount (and the left not at all).

@dankamongmen
Copy link
Owner Author

i think i've got a good fix

@dankamongmen
Copy link
Owner Author

except #1747 is fucking us on alacritty, goddamnit why must everything be so difficult

@dankamongmen
Copy link
Owner Author

this works now everywhere i can test, in all configurations i've tested, except alacritty (see #1747).

@dankamongmen dankamongmen modified the milestones: 3.0.0, 2.4.0 Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant