Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support DECSET/DECRST (CSI ? Pm h) to change where the cursor ends up #6

Merged
merged 3 commits into from
Sep 24, 2021

Conversation

db48x
Copy link

@db48x db48x commented Jun 11, 2021

after printing a sixel image. The default is for the cursor to be
moved to the first column of the line after the image. When we receive
CSI ? 8452 h, we will instead leave the cursor on the last line of the
image, on the next column past the end of the image.

after printing a sixel image. The default is for the cursor to be
moved to the first column of the line after the image. When we receive
CSI ? 8452 h, we will instead leave the cursor on the last line of the
image, on the next column past the end of the image.
@ayosec
Copy link
Owner

ayosec commented Jun 21, 2021

Hi @db48x. Thanks for the patch.

Do you have any documentation about this mode? The only reference I can find about it is the commit in xterm where it was added (in the version 303c). The changelog for version 304 doesn't mention it:

  • ...
  • reduce bss storage used for ReGIS/Sixel modules, as well as cleanup
    storage usage in other modules.
  • initial changes for ReGIS support (Ross Combs):
    • document control-sequences
    • separate ifdef's for sixel and color-register features
    • add configuration for VT382

The reference to VT382 seems unrelated to the mode. There are no mentions to it in the VT382 programmer reference manual. In the manual, the table 11-2 (page 180) lists known modes by the terminal, and it ends at 20. Also, the (short) chapter 12, about sixel, does not mention any way to control the cursor position after adding the graphic.


I'm unsure about adding it if it is a private extension done in xterm. At least, until the future of the patch is decided.

alacritty_terminal/src/term/mod.rs Outdated Show resolved Hide resolved
alacritty_terminal/src/term/mod.rs Outdated Show resolved Hide resolved
@db48x
Copy link
Author

db48x commented Jun 21, 2021

Hi @db48x. Thanks for the patch.

Do you have any documentation about this mode? The only reference I can find about it is the commit in xterm where it was added (in the version 303c).
[…]
I'm unsure about adding it if it is a private extension done in xterm. At least, until the future of the patch is decided.

https://invisible-island.net/xterm/ctlseqs/ctlseqs.html#h3-Sixel-Graphics:CSI-?-Pm-h.92F

It allows printing graphics near the bottom of the window without getting an extra empty line below the graphics. It may be an xterm extension, but at this point xterm is the primary reference for what sixel support looks like.

I don’t believe that it is related to VT382 either. (I’m not even sure what a VT382 is; I’ve never heard of one before).

@dankamongmen
Copy link

sorry about the comment just posted here; it was intended for another issue =[ how embarrassing

@ayosec ayosec merged commit 18653cf into ayosec:graphics Sep 24, 2021
@ayosec
Copy link
Owner

ayosec commented Sep 24, 2021

Sorry for the delay @db48x.

I tested it and everything seems fine. Thanks for the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants