Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GSM0338: Fix encoding module to be compatible with latest GSM 03.38 standard #149

Merged
merged 1 commit into from
Jul 25, 2020
Merged

GSM0338: Fix encoding module to be compatible with latest GSM 03.38 standard #149

merged 1 commit into from
Jul 25, 2020

Conversation

pali
Copy link
Contributor

@pali pali commented Jul 25, 2020

@pali
GSM0338: Fix encoding module to be compatible with latest GSM 03.38 s…
1f7968e 
…tandard

* Sort mapping table by UNICODE code points and remove duplicates
* Remove byte 0x1B from mapping table as it is invalid / not defined
* Fix algorithm for decoding:
  * Byte 0x00 is not used for escaping in any version of GSM 03.38 standard
  * Fix handling of sequence of escape character 0x1B
  * Fix bug https://rt.cpan.org/Public/Bug/Display.html?id=124571
* Implement DIE_ON_ERR, WARN_ON_ERR, RETURN_ON_ERR and LEAVE_SRC check flags
* Make this GSM0338 implementation compatible with standards:
  * 3GPP TS 23.038 version 16.0.0 Release 16
  * ETSI TS 123 038 V16.0.0 (2020-07)
* Update documentation
  * Fix spelling ETSI
  * Fix UTF-8 vs UNICODE differences
  * Add links to normative documents to SEE ALSO section
  * Add new section how to handle packed septets
  * Add information that this module handles only *default* alphabet (not national)
  * Describe zero byte handling bugs in old versions
* Update tests
  * Remove wrong tests
  * Add test case from bug https://rt.cpan.org/Public/Bug/Display.html?id=124571
* Normative documents are available at:
  * https://www.3gpp.org/dynareport/23038.htm
  * https://www.etsi.org/deliver/etsi_ts/123000_123099/123038/16.00.00_60/ts_123038v160000p.pdf
@dankogai dankogai merged commit 7613bbd into dankogai:master Jul 25, 2020
@dankogai
Copy link
Owner

Thank you!

@happy-barney happy-barney mentioned this pull request Jul 28, 2020
Closed
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Sep 2, 2020
textproc/p5-Encode: Update to 3.07
a850b17 
This also fixes compatibility with perl 5.32

Changelog since 3.05:
3.07 $ $Date: 2020/07/25 12:59:29 $
! lib/Encode/GSM0338.pm t/gsm0338.t
  Pulled: GSM0338: Fix encoding module to be compatible with
    latest  GSM 03.38 standard
  dankogai/p5-encode#149

3.06 2020/05/02 02:32:27
! bin/enc2xs
  address RT#132471: Will not work in 5.32 going forward
  remove the use of lib/unicore/Name.pl
  https://rt.cpan.org/Ticket/Display.html?id=132471
! encoding.pm
  Bump version from 2.22 to 3.00 to address RT#132377
  https://rt.cpan.org/Public/Bug/Display.html?id=132377
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pali @dankogai