Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added unusedFunction self check to CI / cleanups #3526

Merged
merged 12 commits into from
Jan 18, 2022
Merged

Conversation

firewave
Copy link
Collaborator

No description provided.

@firewave firewave force-pushed the ci-unused branch 3 times, most recently from 8d970c3 to a5fa778 Compare December 18, 2021 11:28
@firewave
Copy link
Collaborator Author

I filed https://trac.cppcheck.net/ticket/10660 and https://trac.cppcheck.net/ticket/10661 for the false positives.

@firewave firewave force-pushed the ci-unused branch 2 times, most recently from ee40d06 to 91e9efb Compare December 19, 2021 12:34
@firewave firewave changed the title Ci unused added unusedFunction self check to CI Dec 19, 2021
@firewave firewave force-pushed the ci-unused branch 2 times, most recently from 63407c0 to 031a5ef Compare December 19, 2021 14:08
@firewave
Copy link
Collaborator Author

I filed https://trac.cppcheck.net/ticket/10667 for the preprocessorErrorDirective.

@firewave
Copy link
Collaborator Author

firewave commented Jan 9, 2022

The environment variable is a temporary workaround until we properly disable the ValueFlow based on the configuration.

I will add more tickets for some of the TODOs later on.

I wanted to combine this with the other self check run and parallelize them but the unusedFunction one is very fast so that might not be necessary. It's separate for now but I will bundle it with the other one at a later point.

@firewave firewave changed the title added unusedFunction self check to CI added unusedFunction self check to CI / cleanups Jan 9, 2022
@firewave firewave marked this pull request as ready for review January 9, 2022 07:09
@firewave
Copy link
Collaborator Author

firewave commented Jan 9, 2022

I added https://trac.cppcheck.net/ticket/10697 for the unmatchedSupression TODO.

I would have preferred to have less suppressions in the code but with this we can run it in the CI and will prevent us from accumulating more warnings with future changes. Further cleanups can always be done in future commits.

The disabled run will only make us miss unused function within the test code which is fine as it will still catch all the unused application code.

There's a false negative detected by GCC and Clang as a compiler warning which I will add a ticket for soon.

@firewave
Copy link
Collaborator Author

@danmar This is ready for review.

@danmar danmar merged commit 55ff684 into danmar:main Jan 18, 2022
@firewave firewave deleted the ci-unused branch January 18, 2022 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants