-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added unusedFunction self check to CI / cleanups #3526
Conversation
8d970c3
to
a5fa778
Compare
I filed https://trac.cppcheck.net/ticket/10660 and https://trac.cppcheck.net/ticket/10661 for the false positives. |
ee40d06
to
91e9efb
Compare
63407c0
to
031a5ef
Compare
I filed https://trac.cppcheck.net/ticket/10667 for the |
5491df9
to
5e8cceb
Compare
The environment variable is a temporary workaround until we properly disable the ValueFlow based on the configuration. I will add more tickets for some of the TODOs later on. I wanted to combine this with the other self check run and parallelize them but the unusedFunction one is very fast so that might not be necessary. It's separate for now but I will bundle it with the other one at a later point. |
reduces runtime from several minutes to less than 60 seconds
…ode unused in the actual application
I added https://trac.cppcheck.net/ticket/10697 for the I would have preferred to have less suppressions in the code but with this we can run it in the CI and will prevent us from accumulating more warnings with future changes. Further cleanups can always be done in future commits. The disabled run will only make us miss unused function within the test code which is fine as it will still catch all the unused application code. There's a false negative detected by GCC and Clang as a compiler warning which I will add a ticket for soon. |
@danmar This is ready for review. |
No description provided.