Fix deprecated uses of Redis#pipelined
#438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Context: redis/redis-rb#1059 The following is deprecated ```ruby redis.pipelined do redis.get(key) end ``` And should be rewritten as: ```ruby redis.pipelined do |pipeline| pipeline.get(key) end ``` Functionally it makes no difference. This API is available since Redis 3.0.
danmayer
reviewed
Jan 27, 2022
| files_set.map do |key| | ||
| @redis.hgetall(key) | ||
| @redis.pipelined { |pipeline| | ||
| files_set.each do |key| |
There was a problem hiding this comment.
any reason the map moved to an each?
There was a problem hiding this comment.
Yes because the return value doesn't matter. pipelined doesn't care about what the block returns.
|
@danmayer You said merged, but you only approved. Not sure if you realized that. |
|
oops sorry merged... I will try to get a release out in the next day or two @natematykiewicz / @casperisfine |
|
No big deal It's just a warning and people have a flag to silence them. |
|
OK, sorry for the delay, this has been released in 5.2.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: redis/redis-rb#1059
The following is deprecated
And should be rewritten as:
Functionally it makes no difference.
This API is available since Redis 3.0.