Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip passed results for both report table and fetching logs #49

Merged
merged 3 commits into from
Feb 27, 2024

Conversation

pholica
Copy link
Collaborator

@pholica pholica commented Aug 31, 2023

Resolves #42

@danmyway
Copy link
Owner

Works as intended, thanks @pholica!

❯ tesar report --short -l2 -c http://artifacts.osci.redhat.com/testing-farm/9d129ea9-e633-44e6-a6fd-bc84a9ac447c/ --download-logs --skip-pass
Reporting for the requested tasks:
CentOS-8-latest tier0/non-destructive https://api.dev.testing-farm.io/v0.1/requests/9d129ea9-e633-44e6-a6fd-bc84a9ac447c COMPLETE
  > Downloading the log files.
    > Logfiles stored in /var/tmp/tesar/logs/9d129ea9-e633-44e6-a6fd-bc84a9ac447c_logs
+--------------------------------------+-----------------+-----------------+-------------------------------------+--------+
| UUID                                 | Target          | Test Plan       | Test Case                           | Result |
+--------------------------------------+-----------------+-----------------+-------------------------------------+--------+
| 9d129ea9-e633-44e6-a6fd-bc84a9ac447c | CentOS-8-latest |                 |                                     |        |
|                                      |                 | non-destructive |                                     | FAILED |
|                                      |                 |                 | backup_os_release_no_envar          | FAILED |
|                                      |                 |                 | backup_os_release_with_envar        | FAILED |
|                                      |                 |                 | unsuccessful_satellite_registration | FAILED |
|                                      |                 |                 | empty_username_and_password         | FAILED |
+--------------------------------------+-----------------+-----------------+-------------------------------------+--------+

❯ tree /var/tmp/tesar/logs/9d129ea9-e633-44e6-a6fd-bc84a9ac447c_logs/
9d129ea9-e633-44e6-a6fd-bc84a9ac447c_logs/
└── non-destructive
    ├── CentOS-8-latest_backup_os_release_no_envar.log
    ├── CentOS-8-latest_backup_os_release_with_envar.log
    ├── CentOS-8-latest_empty_username_and_password.log
    └── CentOS-8-latest_unsuccessful_satellite_registration.log

Copy link
Owner

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from my point of view, thanks!
Please just append the CHANGELOG, README and add code comments, we don't need to bulk up my technical debt, thank you!
Also the debug messages would be nice as well :)

@pholica
Copy link
Collaborator Author

pholica commented Sep 1, 2023

Thank you for the review. I'm going to fix as much as it's reasonable before I leave for one week. It's possible that not all of the items will be addressed this (and effectively next week).

@pholica
Copy link
Collaborator Author

pholica commented Feb 20, 2024

Hmmm, the readme update touches also other options as I merely ran the tesar report -h and copied the output so it seems the readme was not updated in one of the previous commits which introduced the change.

@pholica
Copy link
Collaborator Author

pholica commented Feb 20, 2024

@danmyway Please review, I believe it should be now eligible for merge.

Copy link
Owner

@danmyway danmyway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and the changes are super helpful!
Thanks, @pholica

@danmyway danmyway merged commit b626f49 into danmyway:devel Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

report command: download logs of failed tests only
2 participants