added tests about excluding files and metric threshold

dann · Jan 7, 2012 · e51330a · e51330a
1 parent bffa053
commit e51330a
Show file tree

Hide file tree

Showing 6 changed files with 254 additions and 4 deletions.
diff --git a/lib/Test/Perl/Metrics/Lite.pm b/lib/Test/Perl/Metrics/Lite.pm
@@ -1,6 +1,6 @@
 package Test::Perl::Metrics::Lite;
 use strict;
-our $VERSION = '0.1';
+our $VERSION = '0.2';
 
 use List::MoreUtils qw(any);
 use Perl::Metrics::Lite;
@@ -49,10 +49,10 @@ sub _starting_points {
 }
 
 sub all_metrics_ok {
-    my %param = @_;
+    my @dirs = @_;
+
     Test::More::plan('no_plan');
 
-    my @dirs = @_;
     if ( not @dirs ) {
         @dirs = _starting_points();
     }

diff --git a/t/01_bacit.t b/t/01_bacit.t
@@ -2,7 +2,7 @@ use strict;
 use warnings;
 use FindBin;
 use File::Spec;
-use lib File::Spec->catdir($FindBin::Bin, 'lib');
+use lib File::Spec->catdir($FindBin::Bin, 't', 'lib');
 
 use Test::Perl::Metrics::Lite;
 

diff --git a/t/02_except.t b/t/02_except.t
@@ -0,0 +1,11 @@
+use strict;
+use warnings;
+use FindBin;
+use File::Spec;
+use lib File::Spec->catdir( $FindBin::Bin, 'lib' );
+
+use Test::Perl::Metrics::Lite ( -except_file => ['t/lib/Bad/BadClass.pm'] );
+
+BEGIN {
+    all_metrics_ok( ('t/lib') );
+}
diff --git a/t/03_threshold.t b/t/03_threshold.t
@@ -0,0 +1,11 @@
+use strict;
+use warnings;
+use FindBin;
+use File::Spec;
+use lib File::Spec->catdir( $FindBin::Bin, 'lib' );
+
+use Test::Perl::Metrics::Lite (-mccabe_complexity => 300, -loc => 300);
+
+BEGIN {
+    all_metrics_ok( ('t/lib') );
+}
diff --git a/t/lib/Bad/BadClass.pm b/t/lib/Bad/BadClass.pm
@@ -0,0 +1,217 @@
+package Bad::BadClass;
+
+sub long_method {
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+    print;
+}
+
+sub complex_method {
+    my $case = "dog";
+    if ( $case eq "1" ) {
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+    elsif ( $case eq "2" ) {
+        print "hello";
+
+    }
+
+}
+
+1;
diff --git a/t/lib/Good/GoodClass.pm b/t/lib/Good/GoodClass.pm
@@ -0,0 +1,11 @@
+package Good::GoodClass;
+
+sub short_method {
+    return 1;
+}
+
+sub simple_method {
+    return 1;
+}
+
+1;