-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add theoneprobe provider for panels [wip] #29
Conversation
Oops! I didn't mean to mark it ready to review. |
Looks great so far! I think I'm going to work on something like the vanilla BlockPos class for cell positions. There are many instances in my code where I'm doing things like this: |
I also had the idea for a PanelCellPos class. A few things still need to be done, though. Well actually only add a addProbeInfo method to each component class. |
some notes for me:
|
Hopefully, my last commit doesn't mess with you too much. I tried to avoid changes that would conflict with what you're doing. |
@dannydjdk |
How difficult would it be to put the PanelCellPos code in a separate pull request? One feature I want to look into soon is vertical placement, and that feature will be quite useful. I can try to extract it myself if you want to stay focused on moving forward with TOP. |
@dannydjdk i can do it tomorow. No problem. |
No rush. I won't have a lot of time weekend. |
@dannydjdk I think I can even have everything ready tomorrow. Then you can merge the complete pull request if you like. |
@dannydjdk is there anything else you'd like to have in there? |
How well does it perform? Have you noticed any lag when quickly scanning over a lot of components? If so, it might be a good idea to only show the component details if you have a wrench or component in your hand. That's how Chisels & Bits works. If there's no performance issues, then I think it would be nicer if it just showed all the time. |
@dannydjdk Config options could be: |
If you think it's something you could do fairly quickly, you could use this request. Otherwise, a second request could be nice. I'll leave it up to you. |
Is actually already almost done xD. |
I think the code can be tweaked here and there, but for now it should be okay. |
Very nice! |
you can use the creative probe. |
I swear I tried the creative probe and it didn't work, but it works now. 🤓 |
What can be is that you have disabled the trial support in the settings. Currently it does not show any debug information. But would perhaps make sense that I change that in debug mode the data are displayed. Possibly also that the cover is ignored. But I prefer to wait xD. Let's see what you still change everything. |
also fixes: #32