[Bug] Incorrect names of items with proper_name property

[piman51277]

Bug description

Certain items in Tf2, such as "The Blutsauger", "The Anger", etc. have a "The" prefixed when in Unique form.
When stringifying the SKUs of such items, the "The" is omitted.
Example:

const { stringify, parseSKU } = require("tf2-item-format/static");
console.log(stringify(parseSKU("36;6"))); //returns "Blutsauger", should be "The Blutsauger"

Examples of affected items

This bug currently affects over 1,200 items

• The Blutsauger
  • Backpack.tf link
• The Warrior's Spirit
  • Backpack.tf link
• The Hair of the Dog
  • Backpack.tf link

Why this matters

Sites such as Backpack.tf respect the "The" prefix, and this module is currently incompatible with their more correct schema system.

Origin of the Bug

This bug originates within a dependency, node-tf2-static-schema. Specifically, the item-names.json file. tf2-item-format blindly trusts this file to resolve SKUs to item names. However, this bug cannot be blamed on tf2-static-schema, as they are providing the correct base name of the item, which is correct in most contexts

Proposed solution

Luckily, the method to find which item names have this prefix is quite simple. Items with the proper_name property set to true within the raw tf2 schema should have the "The" prefix when unique.

• Tf2 wiki
• Typed Schema

However, the name property does not always include the "The" prefix when the prefix is still required. For example, the "The Sun-on-a-Stick" has the name property set to "Sun-on-a-Stick".

In order to keep backwards compatibilty with existing systems, I propose that this fix should be implemented as a separate function, or as an option to the stringify function.

[piman51277]

I have made a rudimentary fix via this module on npm.

[danocmx]

This issue has already been solved by enabling flag in stringify. Example stringify(parseSKU("36;6", { determineUniqueHat: true })). It's not a default option because it would break existing apps.