Drop support for legacy python #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
force-pushed
the
drop-legacy-python
branch
2 times, most recently
from
50d8e0d
to
bcff387
Compare
This appears to be needed for compatibility with newer Python versions. It's unclear why this wasn't previously showing up in CI as fresh runs without code changes do now hit issues which this change appears to resolve. As we're updating `black` here this commit also includes a layout change to placate the formatter.
PeterJCLaw
force-pushed
the
drop-legacy-python
branch
from
bcff387
to
f8e008c
Compare
PeterJCLaw
force-pushed
the
drop-legacy-python
branch
from
f8e008c
to
4170560
Compare
danpalmer
approved these changes
Aug 10, 2022
| @@ -12,7 +12,7 @@ jobs: | |||
| runs-on: ubuntu-20.04 | |||
| strategy: | |||
| matrix: | |||
| python-version: [3.6, 3.7, 3.8, 3.9] | |||
| python-version: [3.7, 3.8, 3.9] | |||
There was a problem hiding this comment.
Do you want to add 3.10 to this?
| @@ -1,10 +1,9 @@ | |||
| [tox] | |||
| isolated_build = true | |||
| envlist = py{36,37,38,39}-django{22,30,31,32} | |||
| envlist = py{37,38,39}-django{22,30,31,32} | |||
There was a problem hiding this comment.
Can we also try Django 4 here as well? If it doesn't work without further changes don't worry about it, but I think it wasn't a huge change so it might Just Work.
|
Well that'll teach me to review in chronological order. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6
This ends up updating both the linting tools and
poetryused in CI to fix some compile issues that CI was seeing. I'm not sure why those issues were only appearing, but I confirmed via #10 that they weren't caused by the dependency change.They're bundled here as they end up depending on the dependency change in order for
poetryto successfully update the linting tools.