Extend tested Python versions #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterJCLaw
force-pushed
the
extend-tested-versions
branch
3 times, most recently
from
5d1722f
to
26c13d2
Compare
danpalmer
reviewed
Aug 10, 2022
This comment was marked as outdated.
This comment was marked as outdated.
PeterJCLaw
force-pushed
the
extend-tested-versions
branch
from
b92e8a7
to
3038e6a
Compare
Closed
This prevents e.g: 3.0 becoming 3 and matching unexpected things.
danpalmer
approved these changes
Aug 12, 2022
|
Thanks @PeterJCLaw! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #8 to pick up the CI fixes which that includes.It looks like Django 4 will need some actual code changes, or at least test setup changes. This PR therefore only looks at Python versions.
Also included here is a fix such that the Django "3.0" tests actually only test
3.0and not everything.