unpin requirements and make testing use tox #325
Conversation
yiwensong
commented
Aug 27, 2018
yiwensong
commented
- marked a bunch of tests as broken (because they were broken for me)
- switch to using coverage instead of pytest-cov because pytest-cov does not support py36
- unpin requirements to make installation less collision with other packages
- add python 3.6
There was a problem hiding this comment.
Hey, thanks @yiwensong for the contribution, generally looks great to me. Ive also started some very similar changes. Will submit a PR too and we can compare and consolidate
| @@ -3,16 +3,18 @@ | |||
| from setuptools import setup, find_packages | |||
|
|
|||
| install_requires = [ | |||
| 'dateutils', | |||
| 'sortedcontainers>=1.5.9', | |||
There was a problem hiding this comment.
these are test requirements that we don't want in the setup.py
| pymongo>=3.5.1 | ||
| pytest | ||
| requests>=2.13.0 | ||
| six>=1.10.0 |
There was a problem hiding this comment.
I think we can get rid of this file and just have our requirements in setup.py. No point maintaining versions in two places
There was a problem hiding this comment.
I think this file is used in the Dockerfile? I haven't looked into what the docker does, but I kept it in case it was important.
|
For reference please see #326 where I have fixed up our CI. If you have any improvements let me know :) |
|
@alimcmaster1 I'll drop my PR because it looks like we're doing very similar things. I'll make a new one on top of your branch that unpins the requirements. |
|
Thanks that would be great, thanks for contributing!!!
…On Mon, 27 Aug 2018 at 22:39, Yiwen Song ***@***.***> wrote:
@alimcmaster1 <https://github.com/alimcmaster1> I'll drop my PR because
it looks like we're doing very similar things. I'll make a new one on top
of your branch that unpins the requirements.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#325 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AP9Vsq_04d34apUHGb50EYMx0vFlnl41ks5uVGb0gaJpZM4WOVe3>
.
|
